[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 26 00:11:21 PST 2019

labath added a comment.

I also think it would be great to group all host-specific functionality into a common library (other than Utility, since that already has a lot of other stuff in it).

I understand the desire to start with a clean slate for a new tool, so a new would-be-host folder might be a good middle ground between using host as-is and shoving everything into Utility. It will create some "git blame" churn, but probably won't be that bad overall. I probably wouldn't do it that way, because I think we're not far from "fixing" Host (you can help by reviewing D58167 <https://reviews.llvm.org/D58167>, I am waiting for your responses on the comments there), and I don't think it would be so bad to "accidentally" depend on everything in the interim. However, this seems fine too.

So, bottom line, if everyone is ok with the "staging" System folder, then I am too.



More information about the lldb-commits mailing list