[Lldb-commits] [PATCH] D58664: [Utility] Fix ArchSpec.MergeFrom to correctly merge environments

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 25 23:05:43 PST 2019

xiaobai created this revision.
xiaobai added reviewers: aprantl, labath, JDevlieghere, clayborg.
Herald added subscribers: jdoerfert, srhines.

This behavior was originally added in rL252264 <https://reviews.llvm.org/rL252264> (git commit 76a7f365da)
in order to be extra careful with handling platforms like watchos and tvos.
However, as far as triples go, those two (and others) are treated as OSes and
not environments, so that should not really apply here.

Additionally, this behavior is incorrect and can lead to incorrect ArchSpecs.
Because android is specified as an environment and not an OS, not propogating
the environment can lead to modules and targets being misidentified.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58664.188311.patch
Type: text/x-patch
Size: 6697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190226/5fc030db/attachment.bin>

More information about the lldb-commits mailing list