[Lldb-commits] [PATCH] D58653: [Utility] Allow the value 'unknown' when checking if triple components are unknown

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 25 22:45:06 PST 2019

xiaobai added a comment.

In D58653#1409978 <https://reviews.llvm.org/D58653#1409978>, @JDevlieghere wrote:

> Do we actually need to check the string values in addition to the enum values? It looks like the llvm class tries pretty hard to make that the canonical way to query it. I know triples and arches are pretty tricky in lldb though, so maybe there's a reason that we can't.

I wasn't sure when I was writing this, but I just tried and the tests seem to pass when we just check the enum values so I presume it's fine.



More information about the lldb-commits mailing list