[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 25 17:35:04 PST 2019

jingham added a comment.

Utility is supposed to be a bunch of stand-alone utility files & headers that we gather together for convenience's sake.

Host is where we put all the code that is specific to one or another host, and any support files that requires.  For instance, that's why PlatformLinux and friends are there, and all the independent platform directories.  So it is odd to move platform specific defines from Host to Utility.

I don't care much about the name, but having this in Utility when it is setting Host defines and we have a place clearly set out for host support files doesn't seem right.



More information about the lldb-commits mailing list