[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:31
+class CommandProvider;
+struct CommandProviderInfo {
+  static const char *name;
----------------
Doxygen comments?


================
Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:615
 
+  // Reproducer provider.
+  CommandProvider *m_provider = nullptr;
----------------
`///`


================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:121
 
+class lldb_private::CommandProvider
+    : public repro::Provider<lldb_private::CommandProvider> {
----------------
Any toplevel Doxygen comments that would be useful to add here?


================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:132
+
+  void Keep() override {
+    FileSpec file =
----------------
At least from the outside it's not quite obvious what this function does. Could you perhaps add a high-level comment?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58564/new/

https://reviews.llvm.org/D58564