[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

[Michał Górny via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL354617: [lldb] [test] Do not link -ldl on NetBSD (authored by mgorny, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D58517?vs=187826&id=187842#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58517/new/

https://reviews.llvm.org/D58517

Files:
  lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/Makefile
  lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/Makefile
  lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules


Index: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
===================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
+++ lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -415,6 +415,15 @@
 endif
 
 #----------------------------------------------------------------------
+# Additional system libraries
+#----------------------------------------------------------------------
+ifeq (1,$(USE_LIBDL))
+	ifneq ($(OS),NetBSD)
+		LDFLAGS += -ldl
+	endif
+endif
+
+#----------------------------------------------------------------------
 # dylib settings
 #----------------------------------------------------------------------
 ifneq "$(strip $(DYLIB_C_SOURCES))" ""
Index: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/Makefile
===================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/Makefile
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/Makefile
@@ -2,8 +2,9 @@
 
 LIB_PREFIX := loadunload_
 
-LD_EXTRAS := -L. -l$(LIB_PREFIX)d -ldl
+LD_EXTRAS := -L. -l$(LIB_PREFIX)d
 CXX_SOURCES := main.cpp
+USE_LIBDL := 1
 
 include $(LEVEL)/Makefile.rules
 
Index: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/Makefile
===================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/Makefile
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_using_paths/Makefile
@@ -1,7 +1,7 @@
 LEVEL := ../../make
 
 CXX_SOURCES := main.cpp
-LD_EXTRAS := -ldl
+USE_LIBDL := 1
 
 include $(LEVEL)/Makefile.rules
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58517.187842.patch
Type: text/x-patch
Size: 1753 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190221/5899bb45/attachment.bin>