[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 20 23:49:37 PST 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

LGTM. I'd maybe rename InitializeReplay into Replay (i.e., do the merging the other way around), since the `Initialize` part makes me think the replay will not actually commence there.

I forgot that we don't return STL objects through the API. It's a shame we have to resort to the `static std::string` hack. Another option would be to ConstStringify the string, but as these are functions that are to be called just once, this should do too.



More information about the lldb-commits mailing list