[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

Mon Feb 18 10:54:35 PST 2019

krytarowski added inline comments.

================
Comment at: lldb/lit/Modules/ELF/netbsd-core.test:3
+
+# RUN: lldb-test object-file %S/Inputs/netbsd.core | FileCheck %s
+# CHECK: Architecture: x86_64-unknown-netbsd
----------------
krytarowski wrote:
> I propose to keep it as netbsd$VERSION-$ARCH.core
> 
> We will want multiple core(5) files and possible with variations (FPU layout).
> We will want multiple core(5) files and possible with variations (FPU layout).

Actually such variations will be applicable for https://reviews.llvm.org/D32149 Here we just want `$ARCH`-`$VERSION`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42870/new/

https://reviews.llvm.org/D42870