[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked 2 inline comments as done.
teemperor added a comment.

@labath Thanks for the hint with the sysroot, but I'm not really sure what's the best way to test this. Making a whole fake sysroot that can be used to compile a std module seems overkill, and not sure if symlinking or so is a good approach either. I'm open to suggestions.



================
Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/main.cpp:1
+#include <iostream>
+
----------------
shafik wrote:
> Looks like you are relying on `iostream` to bring in `cstdlib` which is not guaranteed. 
We actually always import the whole `std` module, not only the submodule that is used in the program. (Partly because we don't use the submodule visibility feature and partly because I don't see any disadvantage in doing that).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58125/new/

https://reviews.llvm.org/D58125