[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D58193#1398458 <https://reviews.llvm.org/D58193#1398458>, @xiaobai wrote:

> I think it's useful to be able to fully test lldb if you have all the available tools even if it's built standalone. This is especially relevant for swift-lldb, which more often than not is built standalone because swift is often built standalone. I'm generally not in favor of keeping things around only because somebody downstream uses it, but I can see the usefulness for people who work on upstream LLDB as well. I'm not sure if other people feel the same way though.


I certainly agree with that, but I don't see how fiddling with LLDB_TEST_DEPS is going to help testing at all. AFAICT, all it does it set's up the dependencies in the cmake graph. That is not going to help you run the tests. If the tools are there, the tests will run fine; if they aren't the tests will fail.

Now if we were talking about detecting the available tools and automatically warning about their absence and/or skipping tests, that would be a different story, but I don't see anyone proposing that...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58193/new/

https://reviews.llvm.org/D58193