[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

Thu Feb 14 06:25:53 PST 2019

labath marked 3 inline comments as done.
labath added inline comments.

================
Comment at: include/lldb/Core/Module.h:1108-1110
+  llvm::Optional<UnwindTable> m_unwind_table; /// < Table of FuncUnwinders
+                                              /// objects created for this
+                                              /// Module's functions
----------------
clayborg wrote:
> Any reason to not just have a UnwindTable instance here? The accessor can't fail, so one must be created anyway right?
The difference is in when it gets created. The regular instance would have to be created together with the Module. However, that shouldn't really matter, as UnwindTable is internally lazily initialized as well, so I'll just remove the optional. We may need to do something smarter here anyway once we start re-initializing the unwind info due to symbol file changes.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58129/new/

https://reviews.llvm.org/D58129