[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 14 05:17:24 PST 2019


labath added inline comments.


================
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:415
             # Add zero-fill to the right/end (MSB side) of the value.
-            retval += "00" * (byte_size - len(retval) / 2)
+            retval += "00" * (byte_size - len(retval) // 2)
         return retval
----------------
serge-sans-paille wrote:
> Maybe `from __future__ import division` to make sure the `/` operator behaves consistently across versions? That way it may uncover missed `/` to `//` conversion?
That sounds like a good idea. I didn't know about that. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58177/new/

https://reviews.llvm.org/D58177





More information about the lldb-commits mailing list