[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: krytarowski, labath, zturner.
mgorny added a project: LLDB.

The two following LLDBServerTests fail reliably on NetBSD:

StandardStartupTest.TestStopReplyContainsThreadPcs
 TestBase.LaunchModePreservesEnvironment

Establish an XFAIL behavior to let buildbots test for regressions
while we are still working on fixing them.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D58223

Files:
  lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp
  lldb/unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp


Index: lldb/unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp
===================================================================
--- lldb/unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp
+++ lldb/unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp
@@ -29,6 +29,10 @@
       Succeeded());
 
   ASSERT_THAT_ERROR(Client->ListThreadsInStopReply(), Succeeded());
+#if defined(__NetBSD__)
+  // XFAIL: this test currently fails on NetBSD
+  ASSERT_THAT_ERROR(Client->ContinueAll(), Failed());
+#else
   ASSERT_THAT_ERROR(Client->ContinueAll(), Succeeded());
   unsigned int pc_reg = Client->GetPcRegisterId();
   ASSERT_NE(pc_reg, UINT_MAX);
@@ -50,4 +54,5 @@
     EXPECT_THAT(thread_infos[tid].ReadRegister(pc_reg),
                 Pointee(Eq(stop_reply_pc.second)));
   }
+#endif
 }
Index: lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp
===================================================================
--- lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp
+++ lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp
@@ -22,11 +22,16 @@
   ASSERT_THAT_EXPECTED(ClientOr, Succeeded());
   auto &Client = **ClientOr;
 
+#if defined(__NetBSD__)
+  // XFAIL: this test currently fails on NetBSD
+  ASSERT_THAT_ERROR(Client.ContinueAll(), Failed());
+#else
   ASSERT_THAT_ERROR(Client.ContinueAll(), Succeeded());
   ASSERT_THAT_EXPECTED(
       Client.GetLatestStopReplyAs<StopReplyExit>(),
       HasValue(testing::Property(&StopReply::getKind,
                                  WaitStatus{WaitStatus::Exit, 0})));
+#endif
 }
 
 TEST_F(TestBase, DS_TEST(DebugserverEnv)) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58223.186800.patch
Type: text/x-patch
Size: 1612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190214/dc35b54f/attachment-0001.bin>