[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

Wed Feb 13 22:59:17 PST 2019

labath added a comment.

Looks good to me now. I think that, for completeness, you ought to add the DYLD plugin to the list of dependencies for in the CMakeLists.txt for ProcessWindows. Thanks for putting up with me.

================
Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.h:94

+  DynamicLoaderWindowsDYLD *GetDynamicLoader();
+
----------------
add `override`

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56237/new/

https://reviews.llvm.org/D56237