[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

[Davide Italiano via Phabricator via lldb-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

LGTM with one comment.



================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:252-262
+
+  if (repro::Generator *g = repro::Reproducer::Instance().GetGenerator()) {
+    repro::FileProvider &fp = g->GetOrCreate<repro::FileProvider>();
+    m_compiler->setModuleDepCollector(
+        std::make_shared<ModuleDependencyCollectorAdaptor>(
+            fp.GetFileCollector()));
+    DependencyOutputOptions &opts = m_compiler->getDependencyOutputOpts();
----------------
can you add a comment like: "when recording, set up the state to collect the modules, etc..".


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58076/new/

https://reviews.llvm.org/D58076