[Lldb-commits] [PATCH] D58090: [WIP] Deserialize Clang module search path from DWARF

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: jdoerfert.

+1. That's a cleaner version of what I had to do in D58125 <https://reviews.llvm.org/D58125>, so feel free to commit when done. The code is similar enough that rebasing my patch on top shouldn't take too much time.



================
Comment at: include/lldb/Symbol/SourceModule.h:13
+#include <vector>
+
+namespace lldb_private {
----------------
Should also include `lldb/Utility/ConstString.h` otherwise this breaks the module build.


================
Comment at: source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:320
+    for (auto &imported_module : imported_modules) {
       std::vector<ConstString> path;
+      if (!AddModule(imported_module, &exported_modules, error_stream))
----------------
path is unused.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58090/new/

https://reviews.llvm.org/D58090