[Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

[Pavel Labath via lldb-commits]

On 12/02/2019 01:30, Jonas Devlieghere via lldb-commits wrote:
> Author: jdevlieghere
> Date: Mon Feb 11 16:30:21 2019
> New Revision: 353778
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=353778&view=rev
> Log:
> Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.
> 
> Apparently there are multiple places where MSVC complains about
> instantiations with extended aligment. I think it's better to define
> `_ENABLE_EXTENDED_ALIGNED_STORAGE` as suggested by the error message.
> 
> I don't have access to a Windows machine so this is all speculative.
> 

I think it would be worth investigating where is this large alignment 
coming from (my guess: something inside the RegisterContextDarwin 
structs). We've had a case in the past where we were heap-allocating a 
struct with a 64-byte alignment. MSVC would give a warning there, but 
gcc&clang would silently under-align the result.

In that case, the large alignment was actually unneeded, so I fixed both 
issues by just lowering it. I suspect something similar may be possible 
here.

pl