[Lldb-commits] [lldb] r353795 - Remove redundant ::get() for smart pointer. (NFC)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 11 19:47:39 PST 2019


Author: jdevlieghere
Date: Mon Feb 11 19:47:39 2019
New Revision: 353795

URL: http://llvm.org/viewvc/llvm-project?rev=353795&view=rev
Log:
Remove redundant ::get() for smart pointer. (NFC)

This commit removes redundant calls to smart pointer’s ::get() method.

https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-smartptr-get.html

Modified:
    lldb/trunk/source/Breakpoint/Breakpoint.cpp
    lldb/trunk/source/Breakpoint/BreakpointLocation.cpp
    lldb/trunk/source/Breakpoint/BreakpointLocationList.cpp
    lldb/trunk/source/Breakpoint/BreakpointOptions.cpp
    lldb/trunk/source/Breakpoint/BreakpointSiteList.cpp
    lldb/trunk/source/Breakpoint/Watchpoint.cpp
    lldb/trunk/source/Breakpoint/WatchpointOptions.cpp
    lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp
    lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp
    lldb/trunk/source/Expression/IRExecutionUnit.cpp
    lldb/trunk/source/Expression/LLVMUserExpression.cpp
    lldb/trunk/source/Host/common/File.cpp
    lldb/trunk/source/Host/common/Terminal.cpp
    lldb/trunk/source/Interpreter/CommandInterpreter.cpp
    lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
    lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
    lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
    lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
    lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
    lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
    lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
    lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp
    lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp
    lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
    lldb/trunk/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp
    lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
    lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
    lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp
    lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp
    lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp
    lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp
    lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
    lldb/trunk/source/Symbol/ClangASTContext.cpp
    lldb/trunk/source/Symbol/CompileUnit.cpp
    lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp
    lldb/trunk/source/Symbol/ObjectFile.cpp
    lldb/trunk/source/Symbol/SymbolContext.cpp
    lldb/trunk/source/Symbol/SymbolFile.cpp
    lldb/trunk/source/Symbol/SymbolVendor.cpp
    lldb/trunk/source/Target/Language.cpp
    lldb/trunk/source/Target/SectionLoadHistory.cpp
    lldb/trunk/source/Target/Target.cpp
    lldb/trunk/source/Target/Thread.cpp
    lldb/trunk/unittests/Editline/EditlineTest.cpp

Modified: lldb/trunk/source/Breakpoint/Breakpoint.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/Breakpoint.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/Breakpoint.cpp (original)
+++ lldb/trunk/source/Breakpoint/Breakpoint.cpp Mon Feb 11 19:47:39 2019
@@ -59,7 +59,7 @@ Breakpoint::Breakpoint(Target &target, S
 Breakpoint::Breakpoint(Target &new_target, Breakpoint &source_bp)
     : m_being_created(true), m_hardware(source_bp.m_hardware),
       m_target(new_target), m_name_list(source_bp.m_name_list),
-      m_options_up(new BreakpointOptions(*source_bp.m_options_up.get())),
+      m_options_up(new BreakpointOptions(*source_bp.m_options_up)),
       m_locations(*this),
       m_resolve_indirect_symbols(source_bp.m_resolve_indirect_symbols),
       m_hit_count(0) {

Modified: lldb/trunk/source/Breakpoint/BreakpointLocation.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/BreakpointLocation.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/BreakpointLocation.cpp (original)
+++ lldb/trunk/source/Breakpoint/BreakpointLocation.cpp Mon Feb 11 19:47:39 2019
@@ -71,7 +71,7 @@ Target &BreakpointLocation::GetTarget()
 bool BreakpointLocation::IsEnabled() const {
   if (!m_owner.IsEnabled())
     return false;
-  else if (m_options_ap.get() != nullptr)
+  else if (m_options_ap != nullptr)
     return m_options_ap->IsEnabled();
   else
     return true;
@@ -107,7 +107,7 @@ void BreakpointLocation::SetThreadID(lld
   else {
     // If we're resetting this to an invalid thread id, then don't make an
     // options pointer just to do that.
-    if (m_options_ap.get() != nullptr)
+    if (m_options_ap != nullptr)
       m_options_ap->SetThreadID(thread_id);
   }
   SendBreakpointLocationChangedEvent(eBreakpointEventTypeThreadChanged);
@@ -129,7 +129,7 @@ void BreakpointLocation::SetThreadIndex(
   else {
     // If we're resetting this to an invalid thread id, then don't make an
     // options pointer just to do that.
-    if (m_options_ap.get() != nullptr)
+    if (m_options_ap != nullptr)
       m_options_ap->GetThreadSpec()->SetIndex(index);
   }
   SendBreakpointLocationChangedEvent(eBreakpointEventTypeThreadChanged);
@@ -151,7 +151,7 @@ void BreakpointLocation::SetThreadName(c
   else {
     // If we're resetting this to an invalid thread id, then don't make an
     // options pointer just to do that.
-    if (m_options_ap.get() != nullptr)
+    if (m_options_ap != nullptr)
       m_options_ap->GetThreadSpec()->SetName(thread_name);
   }
   SendBreakpointLocationChangedEvent(eBreakpointEventTypeThreadChanged);
@@ -173,7 +173,7 @@ void BreakpointLocation::SetQueueName(co
   else {
     // If we're resetting this to an invalid thread id, then don't make an
     // options pointer just to do that.
-    if (m_options_ap.get() != nullptr)
+    if (m_options_ap != nullptr)
       m_options_ap->GetThreadSpec()->SetQueueName(queue_name);
   }
   SendBreakpointLocationChangedEvent(eBreakpointEventTypeThreadChanged);
@@ -190,7 +190,7 @@ const char *BreakpointLocation::GetQueue
 }
 
 bool BreakpointLocation::InvokeCallback(StoppointCallbackContext *context) {
-  if (m_options_ap.get() != nullptr && m_options_ap->HasCallback())
+  if (m_options_ap != nullptr && m_options_ap->HasCallback())
     return m_options_ap->InvokeCallback(context, m_owner.GetID(), GetID());
   else
     return m_owner.InvokeCallback(context, GetID());
@@ -344,7 +344,7 @@ void BreakpointLocation::SetIgnoreCount(
 }
 
 void BreakpointLocation::DecrementIgnoreCount() {
-  if (m_options_ap.get() != nullptr) {
+  if (m_options_ap != nullptr) {
     uint32_t loc_ignore = m_options_ap->GetIgnoreCount();
     if (loc_ignore != 0)
       m_options_ap->SetIgnoreCount(loc_ignore - 1);
@@ -352,7 +352,7 @@ void BreakpointLocation::DecrementIgnore
 }
 
 bool BreakpointLocation::IgnoreCountShouldStop() {
-  if (m_options_ap.get() != nullptr) {
+  if (m_options_ap != nullptr) {
     uint32_t loc_ignore = m_options_ap->GetIgnoreCount();
     if (loc_ignore != 0) {
       m_owner.DecrementIgnoreCount();
@@ -369,7 +369,7 @@ BreakpointOptions *BreakpointLocation::G
   // If we make the copy we don't copy the callbacks because that is
   // potentially expensive and we don't want to do that for the simple case
   // where someone is just disabling the location.
-  if (m_options_ap.get() == nullptr)
+  if (m_options_ap == nullptr)
     m_options_ap.reset(
         new BreakpointOptions(false));
 
@@ -603,7 +603,7 @@ void BreakpointLocation::GetDescription(
     s->Indent();
     s->Printf("hit count = %-4u\n", GetHitCount());
 
-    if (m_options_ap.get()) {
+    if (m_options_ap) {
       s->Indent();
       m_options_ap->GetDescription(s, level);
       s->EOL();
@@ -612,7 +612,7 @@ void BreakpointLocation::GetDescription(
   } else if (level != eDescriptionLevelInitial) {
     s->Printf(", %sresolved, hit count = %u ", (IsResolved() ? "" : "un"),
               GetHitCount());
-    if (m_options_ap.get()) {
+    if (m_options_ap) {
       m_options_ap->GetDescription(s, level);
     }
   }
@@ -624,18 +624,18 @@ void BreakpointLocation::Dump(Stream *s)
 
   lldb::tid_t tid = GetOptionsSpecifyingKind(BreakpointOptions::eThreadSpec)
       ->GetThreadSpecNoCreate()->GetTID();
-  s->Printf(
-      "BreakpointLocation %u: tid = %4.4" PRIx64 "  load addr = 0x%8.8" PRIx64
-      "  state = %s  type = %s breakpoint  "
-      "hw_index = %i  hit_count = %-4u  ignore_count = %-4u",
-      GetID(), tid,
-      (uint64_t)m_address.GetOpcodeLoadAddress(&m_owner.GetTarget()),
-      (m_options_ap.get() ? m_options_ap->IsEnabled() : m_owner.IsEnabled())
-          ? "enabled "
-          : "disabled",
-      IsHardware() ? "hardware" : "software", GetHardwareIndex(), GetHitCount(),
-      GetOptionsSpecifyingKind(BreakpointOptions::eIgnoreCount)
-          ->GetIgnoreCount());
+  s->Printf("BreakpointLocation %u: tid = %4.4" PRIx64
+            "  load addr = 0x%8.8" PRIx64 "  state = %s  type = %s breakpoint  "
+            "hw_index = %i  hit_count = %-4u  ignore_count = %-4u",
+            GetID(), tid,
+            (uint64_t)m_address.GetOpcodeLoadAddress(&m_owner.GetTarget()),
+            (m_options_ap ? m_options_ap->IsEnabled() : m_owner.IsEnabled())
+                ? "enabled "
+                : "disabled",
+            IsHardware() ? "hardware" : "software", GetHardwareIndex(),
+            GetHitCount(),
+            GetOptionsSpecifyingKind(BreakpointOptions::eIgnoreCount)
+                ->GetIgnoreCount());
 }
 
 void BreakpointLocation::SendBreakpointLocationChangedEvent(

Modified: lldb/trunk/source/Breakpoint/BreakpointLocationList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/BreakpointLocationList.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/BreakpointLocationList.cpp (original)
+++ lldb/trunk/source/Breakpoint/BreakpointLocationList.cpp Mon Feb 11 19:47:39 2019
@@ -129,7 +129,7 @@ void BreakpointLocationList::Dump(Stream
   s->IndentMore();
   collection::const_iterator pos, end = m_locations.end();
   for (pos = m_locations.begin(); pos != end; ++pos)
-    (*pos).get()->Dump(s);
+    (*pos)->Dump(s);
   s->IndentLess();
 }
 

Modified: lldb/trunk/source/Breakpoint/BreakpointOptions.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/BreakpointOptions.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/BreakpointOptions.cpp (original)
+++ lldb/trunk/source/Breakpoint/BreakpointOptions.cpp Mon Feb 11 19:47:39 2019
@@ -158,8 +158,8 @@ BreakpointOptions::BreakpointOptions(con
       m_ignore_count(rhs.m_ignore_count), m_thread_spec_ap(),
       m_auto_continue(rhs.m_auto_continue),
       m_set_flags(rhs.m_set_flags) {
-  if (rhs.m_thread_spec_ap.get() != nullptr)
-    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap.get()));
+  if (rhs.m_thread_spec_ap != nullptr)
+    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap));
   m_condition_text = rhs.m_condition_text;
   m_condition_text_hash = rhs.m_condition_text_hash;
 }
@@ -176,8 +176,8 @@ operator=(const BreakpointOptions &rhs)
   m_enabled = rhs.m_enabled;
   m_one_shot = rhs.m_one_shot;
   m_ignore_count = rhs.m_ignore_count;
-  if (rhs.m_thread_spec_ap.get() != nullptr)
-    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap.get()));
+  if (rhs.m_thread_spec_ap != nullptr)
+    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap));
   m_condition_text = rhs.m_condition_text;
   m_condition_text_hash = rhs.m_condition_text_hash;
   m_auto_continue = rhs.m_auto_continue;
@@ -231,9 +231,9 @@ void BreakpointOptions::CopyOverSetOptio
   if (incoming.m_set_flags.Test(eThreadSpec) && incoming.m_thread_spec_ap)
   {
     if (!m_thread_spec_ap)
-      m_thread_spec_ap.reset(new ThreadSpec(*incoming.m_thread_spec_ap.get()));
+      m_thread_spec_ap.reset(new ThreadSpec(*incoming.m_thread_spec_ap));
     else
-      *m_thread_spec_ap.get() = *incoming.m_thread_spec_ap.get();
+      *m_thread_spec_ap = *incoming.m_thread_spec_ap;
     m_set_flags.Set(eThreadSpec);
   }
 }
@@ -327,7 +327,7 @@ std::unique_ptr<BreakpointOptions> Break
   auto bp_options = llvm::make_unique<BreakpointOptions>(
       condition_ref.str().c_str(), enabled, 
       ignore_count, one_shot, auto_continue);
-  if (cmd_data_up.get()) {
+  if (cmd_data_up) {
     if (cmd_data_up->interpreter == eScriptLanguageNone)
       bp_options->SetCommandDataCallback(cmd_data_up);
     else {
@@ -525,8 +525,7 @@ const ThreadSpec *BreakpointOptions::Get
 }
 
 ThreadSpec *BreakpointOptions::GetThreadSpec() {
-  if (m_thread_spec_ap.get() == nullptr)
-  {
+  if (m_thread_spec_ap == nullptr) {
     m_set_flags.Set(eThreadSpec);
     m_thread_spec_ap.reset(new ThreadSpec());
   }
@@ -573,7 +572,7 @@ void BreakpointOptions::GetDescription(S
     if (m_auto_continue)
       s->Printf("auto-continue ");
 
-    if (m_thread_spec_ap.get())
+    if (m_thread_spec_ap)
       m_thread_spec_ap->GetDescription(s, level);
 
     if (level == lldb::eDescriptionLevelFull) {

Modified: lldb/trunk/source/Breakpoint/BreakpointSiteList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/BreakpointSiteList.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/BreakpointSiteList.cpp (original)
+++ lldb/trunk/source/Breakpoint/BreakpointSiteList.cpp Mon Feb 11 19:47:39 2019
@@ -85,7 +85,7 @@ public:
   BreakpointSiteIDMatches(lldb::break_id_t break_id) : m_break_id(break_id) {}
 
   bool operator()(std::pair<lldb::addr_t, BreakpointSiteSP> val_pair) const {
-    return m_break_id == val_pair.second.get()->GetID();
+    return m_break_id == val_pair.second->GetID();
   }
 
 private:
@@ -157,7 +157,7 @@ void BreakpointSiteList::Dump(Stream *s)
   collection::const_iterator pos;
   collection::const_iterator end = m_bp_site_list.end();
   for (pos = m_bp_site_list.begin(); pos != end; ++pos)
-    pos->second.get()->Dump(s);
+    pos->second->Dump(s);
   s->IndentLess();
 }
 

Modified: lldb/trunk/source/Breakpoint/Watchpoint.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/Watchpoint.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/Watchpoint.cpp (original)
+++ lldb/trunk/source/Breakpoint/Watchpoint.cpp Mon Feb 11 19:47:39 2019
@@ -272,7 +272,7 @@ bool Watchpoint::InvokeCallback(Stoppoin
 
 void Watchpoint::SetCondition(const char *condition) {
   if (condition == nullptr || condition[0] == '\0') {
-    if (m_condition_ap.get())
+    if (m_condition_ap)
       m_condition_ap.reset();
   } else {
     // Pass nullptr for expr_prefix (no translation-unit level definitions).
@@ -290,7 +290,7 @@ void Watchpoint::SetCondition(const char
 }
 
 const char *Watchpoint::GetConditionText() const {
-  if (m_condition_ap.get())
+  if (m_condition_ap)
     return m_condition_ap->GetUserText();
   else
     return nullptr;

Modified: lldb/trunk/source/Breakpoint/WatchpointOptions.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/WatchpointOptions.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/WatchpointOptions.cpp (original)
+++ lldb/trunk/source/Breakpoint/WatchpointOptions.cpp Mon Feb 11 19:47:39 2019
@@ -39,8 +39,8 @@ WatchpointOptions::WatchpointOptions(con
     : m_callback(rhs.m_callback), m_callback_baton_sp(rhs.m_callback_baton_sp),
       m_callback_is_synchronous(rhs.m_callback_is_synchronous),
       m_thread_spec_ap() {
-  if (rhs.m_thread_spec_ap.get() != nullptr)
-    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap.get()));
+  if (rhs.m_thread_spec_ap != nullptr)
+    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap));
 }
 
 //----------------------------------------------------------------------
@@ -51,8 +51,8 @@ operator=(const WatchpointOptions &rhs)
   m_callback = rhs.m_callback;
   m_callback_baton_sp = rhs.m_callback_baton_sp;
   m_callback_is_synchronous = rhs.m_callback_is_synchronous;
-  if (rhs.m_thread_spec_ap.get() != nullptr)
-    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap.get()));
+  if (rhs.m_thread_spec_ap != nullptr)
+    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap));
   return *this;
 }
 
@@ -117,7 +117,7 @@ const ThreadSpec *WatchpointOptions::Get
 }
 
 ThreadSpec *WatchpointOptions::GetThreadSpec() {
-  if (m_thread_spec_ap.get() == nullptr)
+  if (m_thread_spec_ap == nullptr)
     m_thread_spec_ap.reset(new ThreadSpec());
 
   return m_thread_spec_ap.get();
@@ -152,7 +152,7 @@ void WatchpointOptions::GetDescription(S
     } else
       s->PutCString(" Options: ");
 
-    if (m_thread_spec_ap.get())
+    if (m_thread_spec_ap)
       m_thread_spec_ap->GetDescription(s, level);
     else if (level == eDescriptionLevelBrief)
       s->PutCString("thread spec: no ");

Modified: lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp (original)
+++ lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp Mon Feb 11 19:47:39 2019
@@ -141,7 +141,7 @@ void ValueObjectSynthetic::CreateSynthFi
     }
   }
   m_synth_filter_ap = (m_synth_sp->GetFrontEnd(*valobj_for_frontend));
-  if (!m_synth_filter_ap.get())
+  if (!m_synth_filter_ap)
     m_synth_filter_ap = llvm::make_unique<DummySyntheticFrontEnd>(*m_parent);
 }
 
@@ -235,7 +235,7 @@ lldb::ValueObjectSP ValueObjectSynthetic
 
   ValueObject *valobj;
   if (!m_children_byindex.GetValueForKey(idx, valobj)) {
-    if (can_create && m_synth_filter_ap.get() != nullptr) {
+    if (can_create && m_synth_filter_ap != nullptr) {
       if (log)
         log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at "
                     "index %zu not cached and will be created",
@@ -301,13 +301,13 @@ size_t ValueObjectSynthetic::GetIndexOfC
   uint32_t found_index = UINT32_MAX;
   bool did_find = m_name_toindex.GetValueForKey(name.GetCString(), found_index);
 
-  if (!did_find && m_synth_filter_ap.get() != nullptr) {
+  if (!did_find && m_synth_filter_ap != nullptr) {
     uint32_t index = m_synth_filter_ap->GetIndexOfChildWithName(name);
     if (index == UINT32_MAX)
       return index;
     m_name_toindex.SetValueForKey(name.GetCString(), index);
     return index;
-  } else if (!did_find && m_synth_filter_ap.get() == nullptr)
+  } else if (!did_find && m_synth_filter_ap == nullptr)
     return UINT32_MAX;
   else /*if (iter != m_name_toindex.end())*/
     return found_index;

Modified: lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp (original)
+++ lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp Mon Feb 11 19:47:39 2019
@@ -111,7 +111,7 @@ void TypeCategoryMap::EnableAllCategorie
   decltype(sorted_categories)::iterator viter = sorted_categories.begin(),
                                         vend = sorted_categories.end();
   for (; viter != vend; viter++)
-    if (viter->get())
+    if (*viter)
       Enable(*viter, Last);
 }
 

Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRExecutionUnit.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Expression/IRExecutionUnit.cpp (original)
+++ lldb/trunk/source/Expression/IRExecutionUnit.cpp Mon Feb 11 19:47:39 2019
@@ -294,7 +294,7 @@ void IRExecutionUnit::GetRunnableInfo(St
   m_strip_underscore =
       (m_execution_engine_ap->getDataLayout().getGlobalPrefix() == '_');
 
-  if (!m_execution_engine_ap.get()) {
+  if (!m_execution_engine_ap) {
     error.SetErrorToGenericError();
     error.SetErrorStringWithFormat("Couldn't JIT the function: %s",
                                    error_string.c_str());

Modified: lldb/trunk/source/Expression/LLVMUserExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/LLVMUserExpression.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Expression/LLVMUserExpression.cpp (original)
+++ lldb/trunk/source/Expression/LLVMUserExpression.cpp Mon Feb 11 19:47:39 2019
@@ -115,10 +115,9 @@ LLVMUserExpression::DoExecute(Diagnostic
       function_stack_bottom = m_stack_frame_bottom;
       function_stack_top = m_stack_frame_top;
 
-      IRInterpreter::Interpret(*module, *function, args,
-                               *m_execution_unit_sp.get(), interpreter_error,
-                               function_stack_bottom, function_stack_top,
-                               exe_ctx);
+      IRInterpreter::Interpret(*module, *function, args, *m_execution_unit_sp,
+                               interpreter_error, function_stack_bottom,
+                               function_stack_top, exe_ctx);
 
       if (!interpreter_error.Success()) {
         diagnostic_manager.Printf(eDiagnosticSeverityError,

Modified: lldb/trunk/source/Host/common/File.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/File.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/File.cpp (original)
+++ lldb/trunk/source/Host/common/File.cpp Mon Feb 11 19:47:39 2019
@@ -532,7 +532,7 @@ Status File::Read(size_t &num_bytes, off
           data_heap_ap.reset(new DataBufferHeap());
           data_heap_ap->SetByteSize(num_bytes_plus_nul_char);
 
-          if (data_heap_ap.get()) {
+          if (data_heap_ap) {
             error = Read(data_heap_ap->GetBytes(), num_bytes, offset);
             if (error.Success()) {
               // Make sure we read exactly what we asked for and if we got

Modified: lldb/trunk/source/Host/common/Terminal.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Terminal.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/Terminal.cpp (original)
+++ lldb/trunk/source/Host/common/Terminal.cpp Mon Feb 11 19:47:39 2019
@@ -118,7 +118,7 @@ bool TerminalState::Save(int fd, bool sa
     m_tflags = ::fcntl(fd, F_GETFL, 0);
 #endif
 #ifdef LLDB_CONFIG_TERMIOS_SUPPORTED
-    if (m_termios_ap.get() == NULL)
+    if (m_termios_ap == NULL)
       m_termios_ap.reset(new struct termios);
     int err = ::tcgetattr(fd, m_termios_ap.get());
     if (err != 0)
@@ -191,7 +191,7 @@ bool TerminalState::TFlagsIsValid() cons
 //----------------------------------------------------------------------
 bool TerminalState::TTYStateIsValid() const {
 #ifdef LLDB_CONFIG_TERMIOS_SUPPORTED
-  return m_termios_ap.get() != 0;
+  return m_termios_ap != 0;
 #else
   return false;
 #endif

Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/CommandInterpreter.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Interpreter/CommandInterpreter.cpp (original)
+++ lldb/trunk/source/Interpreter/CommandInterpreter.cpp Mon Feb 11 19:47:39 2019
@@ -554,7 +554,7 @@ void CommandInterpreter::LoadCommandDict
                  CommandCompletions::eSourceFileCompletion,
           false));
 
-  if (break_regex_cmd_ap.get()) {
+  if (break_regex_cmd_ap) {
     bool success = true;
     for (size_t i = 0; i < num_regexes; i++) {
       success = break_regex_cmd_ap->AddRegexCommand(break_regexes[i][0],
@@ -603,7 +603,7 @@ void CommandInterpreter::LoadCommandDict
                  CommandCompletions::eSourceFileCompletion,
           false));
 
-  if (tbreak_regex_cmd_ap.get()) {
+  if (tbreak_regex_cmd_ap) {
     bool success = true;
     for (size_t i = 0; i < num_regexes; i++) {
       // If you add a resultant command string longer than 1024 characters be
@@ -632,7 +632,7 @@ void CommandInterpreter::LoadCommandDict
       new CommandObjectRegexCommand(
           *this, "_regexp-attach", "Attach to process by ID or name.",
           "_regexp-attach <pid> | <process-name>", 2, 0, false));
-  if (attach_regex_cmd_ap.get()) {
+  if (attach_regex_cmd_ap) {
     if (attach_regex_cmd_ap->AddRegexCommand("^([0-9]+)[[:space:]]*$",
                                              "process attach --pid %1") &&
         attach_regex_cmd_ap->AddRegexCommand(
@@ -654,7 +654,7 @@ void CommandInterpreter::LoadCommandDict
                                     "moving one frame, a numeric argument can "
                                     "specify an arbitrary number.",
                                     "_regexp-down [<count>]", 2, 0, false));
-  if (down_regex_cmd_ap.get()) {
+  if (down_regex_cmd_ap) {
     if (down_regex_cmd_ap->AddRegexCommand("^$", "frame select -r -1") &&
         down_regex_cmd_ap->AddRegexCommand("^([0-9]+)$",
                                            "frame select -r -%1")) {
@@ -669,7 +669,7 @@ void CommandInterpreter::LoadCommandDict
           "Select an older stack frame.  Defaults to moving one "
           "frame, a numeric argument can specify an arbitrary number.",
           "_regexp-up [<count>]", 2, 0, false));
-  if (up_regex_cmd_ap.get()) {
+  if (up_regex_cmd_ap) {
     if (up_regex_cmd_ap->AddRegexCommand("^$", "frame select -r 1") &&
         up_regex_cmd_ap->AddRegexCommand("^([0-9]+)$", "frame select -r %1")) {
       CommandObjectSP up_regex_cmd_sp(up_regex_cmd_ap.release());
@@ -682,7 +682,7 @@ void CommandInterpreter::LoadCommandDict
           *this, "_regexp-display",
           "Evaluate an expression at every stop (see 'help target stop-hook'.)",
           "_regexp-display expression", 2, 0, false));
-  if (display_regex_cmd_ap.get()) {
+  if (display_regex_cmd_ap) {
     if (display_regex_cmd_ap->AddRegexCommand(
             "^(.+)$", "target stop-hook add -o \"expr -- %1\"")) {
       CommandObjectSP display_regex_cmd_sp(display_regex_cmd_ap.release());
@@ -696,7 +696,7 @@ void CommandInterpreter::LoadCommandDict
           *this, "_regexp-undisplay", "Stop displaying expression at every "
                                       "stop (specified by stop-hook index.)",
           "_regexp-undisplay stop-hook-number", 2, 0, false));
-  if (undisplay_regex_cmd_ap.get()) {
+  if (undisplay_regex_cmd_ap) {
     if (undisplay_regex_cmd_ap->AddRegexCommand("^([0-9]+)$",
                                                 "target stop-hook delete %1")) {
       CommandObjectSP undisplay_regex_cmd_sp(undisplay_regex_cmd_ap.release());
@@ -710,7 +710,7 @@ void CommandInterpreter::LoadCommandDict
           *this, "gdb-remote", "Connect to a process via remote GDB server.  "
                                "If no host is specifed, localhost is assumed.",
           "gdb-remote [<hostname>:]<portnum>", 2, 0, false));
-  if (connect_gdb_remote_cmd_ap.get()) {
+  if (connect_gdb_remote_cmd_ap) {
     if (connect_gdb_remote_cmd_ap->AddRegexCommand(
             "^([^:]+|\\[[0-9a-fA-F:]+.*\\]):([0-9]+)$",
             "process connect --plugin gdb-remote connect://%1:%2") &&
@@ -728,7 +728,7 @@ void CommandInterpreter::LoadCommandDict
                                "If no UDP port is specified, port 41139 is "
                                "assumed.",
           "kdp-remote <hostname>[:<portnum>]", 2, 0, false));
-  if (connect_kdp_remote_cmd_ap.get()) {
+  if (connect_kdp_remote_cmd_ap) {
     if (connect_kdp_remote_cmd_ap->AddRegexCommand(
             "^([^:]+:[[:digit:]]+)$",
             "process connect --plugin kdp-remote udp://%1") &&
@@ -746,7 +746,7 @@ void CommandInterpreter::LoadCommandDict
           "displays at most that many "
           "frames.  The argument 'all' displays all threads.",
           "bt [<digit> | all]", 2, 0, false));
-  if (bt_regex_cmd_ap.get()) {
+  if (bt_regex_cmd_ap) {
     // accept but don't document "bt -c <number>" -- before bt was a regex
     // command if you wanted to backtrace three frames you would do "bt -c 3"
     // but the intention is to have this emulate the gdb "bt" command and so
@@ -775,7 +775,7 @@ void CommandInterpreter::LoadCommandDict
           "_regexp-list -[<count>]      // List previous <count> lines\n"
           "_regexp-list                 // List subsequent lines",
           2, CommandCompletions::eSourceFileCompletion, false));
-  if (list_regex_cmd_ap.get()) {
+  if (list_regex_cmd_ap) {
     if (list_regex_cmd_ap->AddRegexCommand("^([0-9]+)[[:space:]]*$",
                                            "source list --line %1") &&
         list_regex_cmd_ap->AddRegexCommand(
@@ -806,7 +806,7 @@ void CommandInterpreter::LoadCommandDict
           "_regexp-env                  // Show enrivonment\n"
           "_regexp-env <name>=<value>   // Set an environment variable",
           2, 0, false));
-  if (env_regex_cmd_ap.get()) {
+  if (env_regex_cmd_ap) {
     if (env_regex_cmd_ap->AddRegexCommand("^$",
                                           "settings show target.env-vars") &&
         env_regex_cmd_ap->AddRegexCommand("^([A-Za-z_][A-Za-z_0-9]*=.*)$",
@@ -825,7 +825,7 @@ void CommandInterpreter::LoadCommandDict
           "_regexp-jump <file>:<line>\n"
           "_regexp-jump *<addr>\n",
           2, 0, false));
-  if (jump_regex_cmd_ap.get()) {
+  if (jump_regex_cmd_ap) {
     if (jump_regex_cmd_ap->AddRegexCommand("^\\*(.*)$",
                                            "thread jump --addr %1") &&
         jump_regex_cmd_ap->AddRegexCommand("^([0-9]+)$",

Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp Mon Feb 11 19:47:39 2019
@@ -637,7 +637,7 @@ addr_t DynamicLoaderPOSIXDYLD::GetEntryP
   if (m_entry_point != LLDB_INVALID_ADDRESS)
     return m_entry_point;
 
-  if (m_auxv.get() == NULL)
+  if (m_auxv == NULL)
     return LLDB_INVALID_ADDRESS;
 
   AuxVector::iterator I = m_auxv->FindEntry(AuxVector::AUXV_AT_ENTRY);

Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp (original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp Mon Feb 11 19:47:39 2019
@@ -132,7 +132,7 @@ void ClangExpressionDeclMap::DidParse()
   if (log)
     ClangASTMetrics::DumpCounters(log);
 
-  if (m_parser_vars.get()) {
+  if (m_parser_vars) {
     for (size_t entity_index = 0, num_entities = m_found_entities.GetSize();
          entity_index < num_entities; ++entity_index) {
       ExpressionVariableSP var_sp(

Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp (original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Mon Feb 11 19:47:39 2019
@@ -486,7 +486,7 @@ ClangExpressionParser::ClangExpressionPa
   m_file_manager.reset(new clang::FileManager(file_system_options));
 
   if (!m_compiler->hasSourceManager())
-    m_compiler->createSourceManager(*m_file_manager.get());
+    m_compiler->createSourceManager(*m_file_manager);
 
   m_compiler->createFileManager();
   m_compiler->createPreprocessor(TU_Complete);
@@ -1051,7 +1051,7 @@ lldb_private::Status ClangExpressionPars
   std::unique_ptr<llvm::Module> llvm_module_ap(
       m_code_generator->ReleaseModule());
 
-  if (!llvm_module_ap.get()) {
+  if (!llvm_module_ap) {
     err.SetErrorToGenericError();
     err.SetErrorString("IR doesn't contain a module");
     return err;

Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp (original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Mon Feb 11 19:47:39 2019
@@ -63,11 +63,9 @@ ClangUserExpression::ClangUserExpression
     ValueObject *ctx_obj)
     : LLVMUserExpression(exe_scope, expr, prefix, language, desired_type,
                          options),
-      m_type_system_helper(*m_target_wp.lock().get(),
-                           options.GetExecutionPolicy() ==
-                               eExecutionPolicyTopLevel),
-      m_result_delegate(exe_scope.CalculateTarget()),
-      m_ctx_obj(ctx_obj) {
+      m_type_system_helper(*m_target_wp.lock(), options.GetExecutionPolicy() ==
+                                                    eExecutionPolicyTopLevel),
+      m_result_delegate(exe_scope.CalculateTarget()), m_ctx_obj(ctx_obj) {
   switch (m_language) {
   case lldb::eLanguageTypeC_plus_plus:
     m_allow_cxx = true;
@@ -824,7 +822,7 @@ ClangUserExpression::ClangUserExpression
 }
 
 void ClangUserExpression::ClangUserExpressionHelper::CommitPersistentDecls() {
-  if (m_result_synthesizer_up.get()) {
+  if (m_result_synthesizer_up) {
     m_result_synthesizer_up->CommitPersistentDecls();
   }
 }

Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp (original)
+++ lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp Mon Feb 11 19:47:39 2019
@@ -742,13 +742,13 @@ EmulateInstructionARM::CreateInstance(co
       std::unique_ptr<EmulateInstructionARM> emulate_insn_ap(
           new EmulateInstructionARM(arch));
 
-      if (emulate_insn_ap.get())
+      if (emulate_insn_ap)
         return emulate_insn_ap.release();
     } else if (arch.GetTriple().getArch() == llvm::Triple::thumb) {
       std::unique_ptr<EmulateInstructionARM> emulate_insn_ap(
           new EmulateInstructionARM(arch));
 
-      if (emulate_insn_ap.get())
+      if (emulate_insn_ap)
         return emulate_insn_ap.release();
     }
   }

Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp (original)
+++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp Mon Feb 11 19:47:39 2019
@@ -217,7 +217,7 @@ lldb::ModuleSP AppleObjCRuntime::GetObjC
 }
 
 Address *AppleObjCRuntime::GetPrintForDebuggerAddr() {
-  if (!m_PrintForDebugger_addr.get()) {
+  if (!m_PrintForDebugger_addr) {
     const ModuleList &modules = m_process->GetTarget().GetImages();
 
     SymbolContextList contexts;
@@ -329,7 +329,7 @@ bool AppleObjCRuntime::ReadObjCLibrary(c
   // reread it?
   m_objc_trampoline_handler_ap.reset(
       new AppleObjCTrampolineHandler(m_process->shared_from_this(), module_sp));
-  if (m_objc_trampoline_handler_ap.get() != NULL) {
+  if (m_objc_trampoline_handler_ap != NULL) {
     m_read_objc_library = true;
     return true;
   } else
@@ -339,7 +339,7 @@ bool AppleObjCRuntime::ReadObjCLibrary(c
 ThreadPlanSP AppleObjCRuntime::GetStepThroughTrampolinePlan(Thread &thread,
                                                             bool stop_others) {
   ThreadPlanSP thread_plan_sp;
-  if (m_objc_trampoline_handler_ap.get())
+  if (m_objc_trampoline_handler_ap)
     thread_plan_sp = m_objc_trampoline_handler_ap->GetStepThroughDispatchPlan(
         thread, stop_others);
   return thread_plan_sp;
@@ -470,8 +470,8 @@ ValueObjectSP AppleObjCRuntime::GetExcep
   if (!cpp_runtime) return ValueObjectSP();
   auto cpp_exception = cpp_runtime->GetExceptionObjectForThread(thread_sp);
   if (!cpp_exception) return ValueObjectSP();
-  
-  auto descriptor = GetClassDescriptor(*cpp_exception.get());
+
+  auto descriptor = GetClassDescriptor(*cpp_exception);
   if (!descriptor || !descriptor->IsValid()) return ValueObjectSP();
   
   while (descriptor) {

Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp (original)
+++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Mon Feb 11 19:47:39 2019
@@ -1148,7 +1148,7 @@ bool AppleObjCRuntimeV2::HashTableSignat
 ObjCLanguageRuntime::ClassDescriptorSP
 AppleObjCRuntimeV2::GetClassDescriptorFromISA(ObjCISA isa) {
   ObjCLanguageRuntime::ClassDescriptorSP class_descriptor_sp;
-  if (m_non_pointer_isa_cache_ap.get())
+  if (m_non_pointer_isa_cache_ap)
     class_descriptor_sp = m_non_pointer_isa_cache_ap->GetClassDescriptor(isa);
   if (!class_descriptor_sp)
     class_descriptor_sp = ObjCLanguageRuntime::GetClassDescriptorFromISA(isa);
@@ -1310,7 +1310,7 @@ AppleObjCRuntimeV2::UpdateISAToDescripto
   ValueList arguments;
   FunctionCaller *get_class_info_function = nullptr;
 
-  if (!m_get_class_info_code.get()) {
+  if (!m_get_class_info_code) {
     Status error;
     m_get_class_info_code.reset(GetTargetRef().GetUtilityFunctionForLanguage(
         g_get_dynamic_class_info_body, eLanguageTypeObjC,
@@ -1332,7 +1332,7 @@ AppleObjCRuntimeV2::UpdateISAToDescripto
         m_get_class_info_code.reset();
       }
     }
-    if (!m_get_class_info_code.get())
+    if (!m_get_class_info_code)
       return DescriptorMapUpdateResult::Fail();
 
     // Next make the runner function for our implementation utility function.
@@ -1565,7 +1565,7 @@ AppleObjCRuntimeV2::UpdateISAToDescripto
   ValueList arguments;
   FunctionCaller *get_shared_cache_class_info_function = nullptr;
 
-  if (!m_get_shared_cache_class_info_code.get()) {
+  if (!m_get_shared_cache_class_info_code) {
     Status error;
     m_get_shared_cache_class_info_code.reset(
         GetTargetRef().GetUtilityFunctionForLanguage(
@@ -1589,7 +1589,7 @@ AppleObjCRuntimeV2::UpdateISAToDescripto
       }
     }
 
-    if (!m_get_shared_cache_class_info_code.get())
+    if (!m_get_shared_cache_class_info_code)
       return DescriptorMapUpdateResult::Fail();
 
     // Next make the function caller for our implementation utility function.
@@ -1946,7 +1946,7 @@ AppleObjCRuntimeV2::GetActualTypeName(Ob
 }
 
 DeclVendor *AppleObjCRuntimeV2::GetDeclVendor() {
-  if (!m_decl_vendor_ap.get())
+  if (!m_decl_vendor_ap)
     m_decl_vendor_ap.reset(new AppleObjCDeclVendor(*this));
 
   return m_decl_vendor_ap.get();

Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp (original)
+++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp Mon Feb 11 19:47:39 2019
@@ -749,7 +749,7 @@ AppleObjCTrampolineHandler::AppleObjCTra
 
   // Build our vtable dispatch handler here:
   m_vtables_ap.reset(new AppleObjCVTables(process_sp, m_objc_module_sp));
-  if (m_vtables_ap.get())
+  if (m_vtables_ap)
     m_vtables_ap->ReadRegions();
 }
 
@@ -770,7 +770,7 @@ AppleObjCTrampolineHandler::SetupDispatc
 
     // First stage is to make the ClangUtility to hold our injected function:
 
-    if (!m_impl_code.get()) {
+    if (!m_impl_code) {
       if (m_lookup_implementation_function_code != NULL) {
         Status error;
         m_impl_code.reset(exe_ctx.GetTargetRef().GetUtilityFunctionForLanguage(
@@ -864,7 +864,7 @@ AppleObjCTrampolineHandler::GetStepThrou
 
   if (!found_it) {
     uint32_t flags;
-    if (m_vtables_ap.get()) {
+    if (m_vtables_ap) {
       found_it = m_vtables_ap->IsAddressInVTables(curr_pc, flags);
       if (found_it) {
         this_dispatch.name = "vtable";

Modified: lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp Mon Feb 11 19:47:39 2019
@@ -325,7 +325,7 @@ ObjectContainer *ObjectContainerBSDArchi
                                         archive_data_offset, file, file_offset,
                                         length));
 
-      if (container_ap.get()) {
+      if (container_ap) {
         if (archive_sp) {
           // We already have this archive in our cache, use it
           container_ap->SetArchive(archive_sp);
@@ -344,7 +344,7 @@ ObjectContainer *ObjectContainerBSDArchi
           new ObjectContainerBSDArchive(module_sp, data_sp, data_offset, file,
                                         file_offset, length));
 
-      if (container_ap.get()) {
+      if (container_ap) {
         // We already have this archive in our cache, use it
         container_ap->SetArchive(archive_sp);
         return container_ap.release();

Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Mon Feb 11 19:47:39 2019
@@ -1057,7 +1057,7 @@ Address ObjectFileELF::GetBaseAddress()
 // ParseDependentModules
 //----------------------------------------------------------------------
 size_t ObjectFileELF::ParseDependentModules() {
-  if (m_filespec_ap.get())
+  if (m_filespec_ap)
     return m_filespec_ap->GetSize();
 
   m_filespec_ap.reset(new FileSpecList());
@@ -2805,7 +2805,7 @@ Symtab *ObjectFileELF::GetSymtab() {
   if (module_obj_file && module_obj_file != this)
     return module_obj_file->GetSymtab();
 
-  if (m_symtab_ap.get() == NULL) {
+  if (m_symtab_ap == NULL) {
     SectionList *section_list = module_sp->GetSectionList();
     if (!section_list)
       return NULL;

Modified: lldb/trunk/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp Mon Feb 11 19:47:39 2019
@@ -115,7 +115,7 @@ Symtab *ObjectFileJIT::GetSymtab() {
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_symtab_ap.get() == NULL) {
+    if (m_symtab_ap == NULL) {
       m_symtab_ap.reset(new Symtab(this));
       std::lock_guard<std::recursive_mutex> symtab_guard(
           m_symtab_ap->GetMutex());
@@ -134,7 +134,7 @@ bool ObjectFileJIT::IsStripped() {
 }
 
 void ObjectFileJIT::CreateSections(SectionList &unified_section_list) {
-  if (!m_sections_ap.get()) {
+  if (!m_sections_ap) {
     m_sections_ap.reset(new SectionList());
     ObjectFileJITDelegateSP delegate_sp(m_delegate_wp.lock());
     if (delegate_sp) {
@@ -161,7 +161,7 @@ void ObjectFileJIT::Dump(Stream *s) {
     if (sections)
       sections->Dump(s, NULL, true, UINT32_MAX);
 
-    if (m_symtab_ap.get())
+    if (m_symtab_ap)
       m_symtab_ap->Dump(s, NULL, eSortOrderNone);
   }
 }

Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Mon Feb 11 19:47:39 2019
@@ -1312,7 +1312,7 @@ Symtab *ObjectFileMachO::GetSymtab() {
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_symtab_ap.get() == NULL) {
+    if (m_symtab_ap == NULL) {
       m_symtab_ap.reset(new Symtab(this));
       std::lock_guard<std::recursive_mutex> symtab_guard(
           m_symtab_ap->GetMutex());
@@ -4842,7 +4842,7 @@ void ObjectFileMachO::Dump(Stream *s) {
     if (sections)
       sections->Dump(s, NULL, true, UINT32_MAX);
 
-    if (m_symtab_ap.get())
+    if (m_symtab_ap)
       m_symtab_ap->Dump(s, NULL, eSortOrderNone);
   }
 }

Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Mon Feb 11 19:47:39 2019
@@ -552,7 +552,7 @@ Symtab *ObjectFilePECOFF::GetSymtab() {
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_symtab_ap.get() == NULL) {
+    if (m_symtab_ap == NULL) {
       SectionList *sect_list = GetSectionList();
       m_symtab_ap.reset(new Symtab(this));
       std::lock_guard<std::recursive_mutex> guard(m_symtab_ap->GetMutex());
@@ -948,7 +948,7 @@ void ObjectFilePECOFF::Dump(Stream *s) {
     if (sections)
       sections->Dump(s, NULL, true, UINT32_MAX);
 
-    if (m_symtab_ap.get())
+    if (m_symtab_ap)
       m_symtab_ap->Dump(s, NULL, eSortOrderNone);
 
     if (m_dos_header.e_magic)

Modified: lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp (original)
+++ lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp Mon Feb 11 19:47:39 2019
@@ -116,7 +116,7 @@ OperatingSystemPython::OperatingSystemPy
 OperatingSystemPython::~OperatingSystemPython() {}
 
 DynamicRegisterInfo *OperatingSystemPython::GetDynamicRegisterInfo() {
-  if (m_register_info_ap.get() == NULL) {
+  if (m_register_info_ap == NULL) {
     if (!m_interpreter || !m_python_object_sp)
       return NULL;
     Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OS));

Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp (original)
+++ lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp Mon Feb 11 19:47:39 2019
@@ -233,7 +233,7 @@ Status ProcessKDP::DoConnectRemote(Strea
 
   std::unique_ptr<ConnectionFileDescriptor> conn_ap(
       new ConnectionFileDescriptor());
-  if (conn_ap.get()) {
+  if (conn_ap) {
     // Only try once for now.
     // TODO: check if we should be retrying?
     const uint32_t max_retry_count = 1;

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Mon Feb 11 19:47:39 2019
@@ -1022,7 +1022,7 @@ Status ProcessGDBRemote::ConnectToDebugs
                   connect_url.str().c_str());
     std::unique_ptr<ConnectionFileDescriptor> conn_ap(
         new ConnectionFileDescriptor());
-    if (conn_ap.get()) {
+    if (conn_ap) {
       const uint32_t max_retry_count = 50;
       uint32_t retry_count = 0;
       while (!m_gdb_comm.IsConnected()) {

Modified: lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp (original)
+++ lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp Mon Feb 11 19:47:39 2019
@@ -856,7 +856,7 @@ protected:
       // that logging be enabled for a process before libtrace is initialized
       // results in a scenario where no errors occur, but no logging is
       // captured, either.  This step is to eliminate that possibility.
-      plugin.AddInitCompletionHook(*process_sp.get());
+      plugin.AddInitCompletionHook(*process_sp);
     }
 
     // Send configuration to the feature by way of the process. Construct the
@@ -1634,8 +1634,8 @@ bool StructuredDataDarwinLog::InitComple
   }
 
   // Queue the thread plan.
-  auto thread_plan_sp = ThreadPlanSP(
-      new ThreadPlanCallOnFunctionExit(*thread_sp.get(), callback));
+  auto thread_plan_sp =
+      ThreadPlanSP(new ThreadPlanCallOnFunctionExit(*thread_sp, callback));
   const bool abort_other_plans = false;
   thread_sp->QueueThreadPlan(thread_plan_sp, abort_other_plans);
   if (log)

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Mon Feb 11 19:47:39 2019
@@ -1938,7 +1938,7 @@ public:
     m_property_getter_name = rhs.m_property_getter_name;
     m_property_attributes = rhs.m_property_attributes;
 
-    if (rhs.m_metadata_ap.get()) {
+    if (rhs.m_metadata_ap) {
       m_metadata_ap.reset(new ClangASTMetadata());
       *m_metadata_ap = *rhs.m_metadata_ap;
     }

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp Mon Feb 11 19:47:39 2019
@@ -43,7 +43,7 @@ void DWARFDebugInfo::SetDwarfData(Symbol
 }
 
 DWARFDebugAranges &DWARFDebugInfo::GetCompileUnitAranges() {
-  if (m_cu_aranges_ap.get() == NULL && m_dwarf2Data) {
+  if (m_cu_aranges_ap == NULL && m_dwarf2Data) {
     Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_ARANGES));
 
     m_cu_aranges_ap.reset(new DWARFDebugAranges());
@@ -60,8 +60,8 @@ DWARFDebugAranges &DWARFDebugInfo::GetCo
 
     // Make a list of all CUs represented by the arange data in the file.
     std::set<dw_offset_t> cus_with_data;
-    for (size_t n = 0; n < m_cu_aranges_ap.get()->GetNumRanges(); n++) {
-      dw_offset_t offset = m_cu_aranges_ap.get()->OffsetAtIndex(n);
+    for (size_t n = 0; n < m_cu_aranges_ap->GetNumRanges(); n++) {
+      dw_offset_t offset = m_cu_aranges_ap->OffsetAtIndex(n);
       if (offset != DW_INVALID_OFFSET)
         cus_with_data.insert(offset);
     }
@@ -89,7 +89,7 @@ DWARFDebugAranges &DWARFDebugInfo::GetCo
     const bool minimize = true;
     m_cu_aranges_ap->Sort(minimize);
   }
-  return *m_cu_aranges_ap.get();
+  return *m_cu_aranges_ap;
 }
 
 void DWARFDebugInfo::ParseCompileUnitHeadersIfNeeded() {

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp Mon Feb 11 19:47:39 2019
@@ -843,7 +843,7 @@ SymbolFileDWARFDwo *DWARFUnit::GetDwoSym
 dw_offset_t DWARFUnit::GetBaseObjOffset() const { return m_base_obj_offset; }
 
 const DWARFDebugAranges &DWARFUnit::GetFunctionAranges() {
-  if (m_func_aranges_ap.get() == NULL) {
+  if (m_func_aranges_ap == NULL) {
     m_func_aranges_ap.reset(new DWARFDebugAranges());
     Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_ARANGES));
 
@@ -870,6 +870,6 @@ const DWARFDebugAranges &DWARFUnit::GetF
     const bool minimize = false;
     m_func_aranges_ap->Sort(minimize);
   }
-  return *m_func_aranges_ap.get();
+  return *m_func_aranges_ap;
 }
 

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Mon Feb 11 19:47:39 2019
@@ -659,11 +659,11 @@ const DWARFDataExtractor &SymbolFileDWAR
 }
 
 DWARFDebugAbbrev *SymbolFileDWARF::DebugAbbrev() {
-  if (m_abbr.get() == NULL) {
+  if (m_abbr == NULL) {
     const DWARFDataExtractor &debug_abbrev_data = get_debug_abbrev_data();
     if (debug_abbrev_data.GetByteSize() > 0) {
       m_abbr.reset(new DWARFDebugAbbrev());
-      if (m_abbr.get())
+      if (m_abbr)
         m_abbr->Parse(debug_abbrev_data);
     }
   }
@@ -675,13 +675,13 @@ const DWARFDebugAbbrev *SymbolFileDWARF:
 }
 
 DWARFDebugInfo *SymbolFileDWARF::DebugInfo() {
-  if (m_info.get() == NULL) {
+  if (m_info == NULL) {
     static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
     Timer scoped_timer(func_cat, "%s this = %p", LLVM_PRETTY_FUNCTION,
                        static_cast<void *>(this));
     if (get_debug_info_data().GetByteSize() > 0) {
       m_info.reset(new DWARFDebugInfo());
-      if (m_info.get()) {
+      if (m_info) {
         m_info->SetDwarfData(this);
       }
     }
@@ -713,7 +713,7 @@ SymbolFileDWARF::GetDWARFCompileUnit(lld
 }
 
 DWARFDebugRangesBase *SymbolFileDWARF::DebugRanges() {
-  if (m_ranges.get() == NULL) {
+  if (m_ranges == NULL) {
     static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
     Timer scoped_timer(func_cat, "%s this = %p", LLVM_PRETTY_FUNCTION,
                        static_cast<void *>(this));
@@ -723,7 +723,7 @@ DWARFDebugRangesBase *SymbolFileDWARF::D
     else if (get_debug_rnglists_data().GetByteSize() > 0)
       m_ranges.reset(new DWARFDebugRngLists());
 
-    if (m_ranges.get())
+    if (m_ranges)
       m_ranges->Extract(this);
   }
   return m_ranges.get();
@@ -972,7 +972,7 @@ static void ParseDWARFLineTableCallback(
     LineTable *line_table = info->line_table;
 
     // If this is our first time here, we need to create a sequence container.
-    if (!info->sequence_ap.get()) {
+    if (!info->sequence_ap) {
       info->sequence_ap.reset(line_table->CreateLineSequenceContainer());
       assert(info->sequence_ap.get());
     }
@@ -1003,7 +1003,7 @@ bool SymbolFileDWARF::ParseLineTable(Com
                                                    DW_INVALID_OFFSET);
       if (cu_line_offset != DW_INVALID_OFFSET) {
         std::unique_ptr<LineTable> line_table_ap(new LineTable(&comp_unit));
-        if (line_table_ap.get()) {
+        if (line_table_ap) {
           ParseDWARFLineTableCallbackInfo info;
           info.line_table = line_table_ap.get();
 

Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp Mon Feb 11 19:47:39 2019
@@ -142,7 +142,7 @@ lldb::addr_t AppleGetItemInfoHandler::Se
     // First stage is to make the UtilityFunction to hold our injected
     // function:
 
-    if (!m_get_item_info_impl_code.get()) {
+    if (!m_get_item_info_impl_code) {
       if (g_get_item_info_function_code != NULL) {
         Status error;
         m_get_item_info_impl_code.reset(

Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp Mon Feb 11 19:47:39 2019
@@ -146,7 +146,7 @@ lldb::addr_t AppleGetPendingItemsHandler
 
     // First stage is to make the ClangUtility to hold our injected function:
 
-    if (!m_get_pending_items_impl_code.get()) {
+    if (!m_get_pending_items_impl_code) {
       if (g_get_pending_items_function_code != NULL) {
         Status error;
         m_get_pending_items_impl_code.reset(

Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp Mon Feb 11 19:47:39 2019
@@ -157,7 +157,7 @@ AppleGetQueuesHandler::SetupGetQueuesFun
 
     // First stage is to make the ClangUtility to hold our injected function:
 
-    if (!m_get_queues_impl_code_up.get()) {
+    if (!m_get_queues_impl_code_up) {
       if (g_get_current_queues_function_code != NULL) {
         Status error;
         m_get_queues_impl_code_up.reset(

Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp Mon Feb 11 19:47:39 2019
@@ -152,7 +152,7 @@ lldb::addr_t AppleGetThreadItemInfoHandl
 
     // First stage is to make the ClangUtility to hold our injected function:
 
-    if (!m_get_thread_item_info_impl_code.get()) {
+    if (!m_get_thread_item_info_impl_code) {
       Status error;
       if (g_get_thread_item_info_function_code != NULL) {
         m_get_thread_item_info_impl_code.reset(

Modified: lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp (original)
+++ lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp Mon Feb 11 19:47:39 2019
@@ -300,7 +300,7 @@ UnwindAssemblyInstEmulation::CreateInsta
       EmulateInstruction::FindPlugin(arch, eInstructionTypePrologueEpilogue,
                                      NULL));
   // Make sure that all prologue instructions are handled
-  if (inst_emulator_ap.get())
+  if (inst_emulator_ap)
     return new UnwindAssemblyInstEmulation(arch, inst_emulator_ap.release());
   return NULL;
 }

Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Mon Feb 11 19:47:39 2019
@@ -763,7 +763,7 @@ void ClangASTContext::Terminate() {
 }
 
 void ClangASTContext::Finalize() {
-  if (m_ast_ap.get()) {
+  if (m_ast_ap) {
     GetASTMap().Erase(m_ast_ap.get());
     if (!m_ast_owned)
       m_ast_ap.release();
@@ -843,7 +843,7 @@ void ClangASTContext::setASTContext(clan
 }
 
 ASTContext *ClangASTContext::getASTContext() {
-  if (m_ast_ap.get() == nullptr) {
+  if (m_ast_ap == nullptr) {
     m_ast_owned = true;
     m_ast_ap.reset(new ASTContext(*getLanguageOptions(), *getSourceManager(),
                                   *getIdentifierTable(), *getSelectorTable(),
@@ -881,20 +881,20 @@ ClangASTContext *ClangASTContext::GetAST
 }
 
 Builtin::Context *ClangASTContext::getBuiltinContext() {
-  if (m_builtins_ap.get() == nullptr)
+  if (m_builtins_ap == nullptr)
     m_builtins_ap.reset(new Builtin::Context());
   return m_builtins_ap.get();
 }
 
 IdentifierTable *ClangASTContext::getIdentifierTable() {
-  if (m_identifier_table_ap.get() == nullptr)
+  if (m_identifier_table_ap == nullptr)
     m_identifier_table_ap.reset(
         new IdentifierTable(*ClangASTContext::getLanguageOptions(), nullptr));
   return m_identifier_table_ap.get();
 }
 
 LangOptions *ClangASTContext::getLanguageOptions() {
-  if (m_language_options_ap.get() == nullptr) {
+  if (m_language_options_ap == nullptr) {
     m_language_options_ap.reset(new LangOptions());
     ParseLangArgs(*m_language_options_ap, InputKind::ObjCXX, GetTargetTriple());
     //        InitializeLangOptions(*m_language_options_ap, InputKind::ObjCXX);
@@ -903,13 +903,13 @@ LangOptions *ClangASTContext::getLanguag
 }
 
 SelectorTable *ClangASTContext::getSelectorTable() {
-  if (m_selector_table_ap.get() == nullptr)
+  if (m_selector_table_ap == nullptr)
     m_selector_table_ap.reset(new SelectorTable());
   return m_selector_table_ap.get();
 }
 
 clang::FileManager *ClangASTContext::getFileManager() {
-  if (m_file_manager_ap.get() == nullptr) {
+  if (m_file_manager_ap == nullptr) {
     clang::FileSystemOptions file_system_options;
     m_file_manager_ap.reset(new clang::FileManager(file_system_options));
   }
@@ -917,14 +917,14 @@ clang::FileManager *ClangASTContext::get
 }
 
 clang::SourceManager *ClangASTContext::getSourceManager() {
-  if (m_source_manager_ap.get() == nullptr)
+  if (m_source_manager_ap == nullptr)
     m_source_manager_ap.reset(
         new clang::SourceManager(*getDiagnosticsEngine(), *getFileManager()));
   return m_source_manager_ap.get();
 }
 
 clang::DiagnosticsEngine *ClangASTContext::getDiagnosticsEngine() {
-  if (m_diagnostics_engine_ap.get() == nullptr) {
+  if (m_diagnostics_engine_ap == nullptr) {
     llvm::IntrusiveRefCntPtr<DiagnosticIDs> diag_id_sp(new DiagnosticIDs());
     m_diagnostics_engine_ap.reset(
         new DiagnosticsEngine(diag_id_sp, new DiagnosticOptions()));
@@ -933,7 +933,7 @@ clang::DiagnosticsEngine *ClangASTContex
 }
 
 clang::MangleContext *ClangASTContext::getMangleContext() {
-  if (m_mangle_ctx_ap.get() == nullptr)
+  if (m_mangle_ctx_ap == nullptr)
     m_mangle_ctx_ap.reset(getASTContext()->createMangleContext());
   return m_mangle_ctx_ap.get();
 }
@@ -963,16 +963,16 @@ private:
 };
 
 DiagnosticConsumer *ClangASTContext::getDiagnosticConsumer() {
-  if (m_diagnostic_consumer_ap.get() == nullptr)
+  if (m_diagnostic_consumer_ap == nullptr)
     m_diagnostic_consumer_ap.reset(new NullDiagnosticConsumer);
 
   return m_diagnostic_consumer_ap.get();
 }
 
 std::shared_ptr<clang::TargetOptions> &ClangASTContext::getTargetOptions() {
-  if (m_target_options_rp.get() == nullptr && !m_target_triple.empty()) {
+  if (m_target_options_rp == nullptr && !m_target_triple.empty()) {
     m_target_options_rp = std::make_shared<clang::TargetOptions>();
-    if (m_target_options_rp.get() != nullptr)
+    if (m_target_options_rp != nullptr)
       m_target_options_rp->Triple = m_target_triple;
   }
   return m_target_options_rp;
@@ -980,7 +980,7 @@ std::shared_ptr<clang::TargetOptions> &C
 
 TargetInfo *ClangASTContext::getTargetInfo() {
   // target_triple should be something like "x86_64-apple-macosx"
-  if (m_target_info_ap.get() == nullptr && !m_target_triple.empty())
+  if (m_target_info_ap == nullptr && !m_target_triple.empty())
     m_target_info_ap.reset(TargetInfo::CreateTargetInfo(*getDiagnosticsEngine(),
                                                         getTargetOptions()));
   return m_target_info_ap.get();

Modified: lldb/trunk/source/Symbol/CompileUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/CompileUnit.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/CompileUnit.cpp (original)
+++ lldb/trunk/source/Symbol/CompileUnit.cpp Mon Feb 11 19:47:39 2019
@@ -189,7 +189,7 @@ lldb::LanguageType CompileUnit::GetLangu
 }
 
 LineTable *CompileUnit::GetLineTable() {
-  if (m_line_table_ap.get() == nullptr) {
+  if (m_line_table_ap == nullptr) {
     if (m_flags.IsClear(flagsParsedLineTable)) {
       m_flags.Set(flagsParsedLineTable);
       SymbolVendor *symbol_vendor = GetModule()->GetSymbolVendor();

Modified: lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp (original)
+++ lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp Mon Feb 11 19:47:39 2019
@@ -230,7 +230,7 @@ DWARFCallFrameInfo::GetCIE(dw_offset_t c
 
   if (pos != m_cie_map.end()) {
     // Parse and cache the CIE
-    if (pos->second.get() == nullptr)
+    if (pos->second == nullptr)
       pos->second = ParseCIE(cie_offset);
 
     return pos->second.get();

Modified: lldb/trunk/source/Symbol/ObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ObjectFile.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ObjectFile.cpp (original)
+++ lldb/trunk/source/Symbol/ObjectFile.cpp Mon Feb 11 19:47:39 2019
@@ -61,7 +61,7 @@ ObjectFile::FindPlugin(const lldb::Modul
                                                  data_offset, file, file_offset,
                                                  file_size));
 
-            if (object_container_ap.get())
+            if (object_container_ap)
               object_file_sp = object_container_ap->GetObjectFile(file);
 
             if (object_file_sp.get())
@@ -110,7 +110,7 @@ ObjectFile::FindPlugin(const lldb::Modul
                                                    data_offset, file,
                                                    file_offset, file_size));
 
-              if (object_container_ap.get())
+              if (object_container_ap)
                 object_file_sp = object_container_ap->GetObjectFile(file);
 
               if (object_file_sp.get())
@@ -151,7 +151,7 @@ ObjectFile::FindPlugin(const lldb::Modul
               create_object_container_callback(module_sp, data_sp, data_offset,
                                                file, file_offset, file_size));
 
-          if (object_container_ap.get())
+          if (object_container_ap)
             object_file_sp = object_container_ap->GetObjectFile(file);
 
           if (object_file_sp.get())
@@ -607,7 +607,7 @@ void ObjectFile::ClearSymtab() {
 }
 
 SectionList *ObjectFile::GetSectionList(bool update_module_section_list) {
-  if (m_sections_ap.get() == nullptr) {
+  if (m_sections_ap == nullptr) {
     if (update_module_section_list) {
       ModuleSP module_sp(GetModule());
       if (module_sp) {

Modified: lldb/trunk/source/Symbol/SymbolContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/SymbolContext.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/SymbolContext.cpp (original)
+++ lldb/trunk/source/Symbol/SymbolContext.cpp Mon Feb 11 19:47:39 2019
@@ -1070,7 +1070,7 @@ bool SymbolContextSpecifier::SymbolConte
     }
   }
   if (m_type & eFileSpecified) {
-    if (m_file_spec_ap.get()) {
+    if (m_file_spec_ap) {
       // If we don't have a block or a comp_unit, then we aren't going to match
       // a source file.
       if (sc.block == nullptr && sc.comp_unit == nullptr)
@@ -1165,7 +1165,7 @@ void SymbolContextSpecifier::GetDescript
       s->Printf("Module: %s\n", m_module_spec.c_str());
   }
 
-  if (m_type == eFileSpecified && m_file_spec_ap.get() != nullptr) {
+  if (m_type == eFileSpecified && m_file_spec_ap != nullptr) {
     m_file_spec_ap->GetPath(path_str, PATH_MAX);
     s->Indent();
     s->Printf("File: %s", path_str);
@@ -1203,7 +1203,7 @@ void SymbolContextSpecifier::GetDescript
     s->Printf("Class name: %s.\n", m_class_name.c_str());
   }
 
-  if (m_type == eAddressRangeSpecified && m_address_range_ap.get() != nullptr) {
+  if (m_type == eAddressRangeSpecified && m_address_range_ap != nullptr) {
     s->Indent();
     s->PutCString("Address range: ");
     m_address_range_ap->Dump(s, m_target_sp.get(),

Modified: lldb/trunk/source/Symbol/SymbolFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/SymbolFile.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/SymbolFile.cpp (original)
+++ lldb/trunk/source/Symbol/SymbolFile.cpp Mon Feb 11 19:47:39 2019
@@ -59,7 +59,7 @@ SymbolFile *SymbolFile::FindPlugin(Objec
          ++idx) {
       std::unique_ptr<SymbolFile> curr_symfile_ap(create_callback(obj_file));
 
-      if (curr_symfile_ap.get()) {
+      if (curr_symfile_ap) {
         const uint32_t sym_file_abilities = curr_symfile_ap->GetAbilities();
         if (sym_file_abilities > best_symfile_abilities) {
           best_symfile_abilities = sym_file_abilities;
@@ -71,7 +71,7 @@ SymbolFile *SymbolFile::FindPlugin(Objec
         }
       }
     }
-    if (best_symfile_ap.get()) {
+    if (best_symfile_ap) {
       // Let the winning symbol file parser initialize itself more completely
       // now that it has been chosen
       best_symfile_ap->InitializeObject();

Modified: lldb/trunk/source/Symbol/SymbolVendor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/SymbolVendor.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/SymbolVendor.cpp (original)
+++ lldb/trunk/source/Symbol/SymbolVendor.cpp Mon Feb 11 19:47:39 2019
@@ -36,7 +36,7 @@ SymbolVendor *SymbolVendor::FindPlugin(c
        ++idx) {
     instance_ap.reset(create_callback(module_sp, feedback_strm));
 
-    if (instance_ap.get()) {
+    if (instance_ap) {
       return instance_ap.release();
     }
   }
@@ -112,7 +112,7 @@ size_t SymbolVendor::GetNumCompileUnits(
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
     if (m_compile_units.empty()) {
-      if (m_sym_file_ap.get()) {
+      if (m_sym_file_ap) {
         // Resize our array of compile unit shared pointers -- which will each
         // remain NULL until someone asks for the actual compile unit
         // information. When this happens, the symbol file will be asked to
@@ -128,7 +128,7 @@ lldb::LanguageType SymbolVendor::ParseLa
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseLanguage(comp_unit);
   }
   return eLanguageTypeUnknown;
@@ -138,7 +138,7 @@ size_t SymbolVendor::ParseFunctions(Comp
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseFunctions(comp_unit);
   }
   return 0;
@@ -148,7 +148,7 @@ bool SymbolVendor::ParseLineTable(Compil
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseLineTable(comp_unit);
   }
   return false;
@@ -158,7 +158,7 @@ bool SymbolVendor::ParseDebugMacros(Comp
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseDebugMacros(comp_unit);
   }
   return false;
@@ -168,7 +168,7 @@ bool SymbolVendor::ParseSupportFiles(Com
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseSupportFiles(comp_unit, support_files);
   }
   return false;
@@ -178,7 +178,7 @@ bool SymbolVendor::ParseIsOptimized(Comp
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseIsOptimized(comp_unit);
   }
   return false;
@@ -189,7 +189,7 @@ bool SymbolVendor::ParseImportedModules(
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseImportedModules(sc, imported_modules);
   }
   return false;
@@ -199,7 +199,7 @@ size_t SymbolVendor::ParseBlocksRecursiv
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseBlocksRecursive(func);
   }
   return 0;
@@ -209,7 +209,7 @@ size_t SymbolVendor::ParseTypes(CompileU
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseTypes(comp_unit);
   }
   return 0;
@@ -219,7 +219,7 @@ size_t SymbolVendor::ParseVariablesForCo
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ParseVariablesForContext(sc);
   }
   return 0;
@@ -229,7 +229,7 @@ Type *SymbolVendor::ResolveTypeUID(lldb:
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ResolveTypeUID(type_uid);
   }
   return nullptr;
@@ -241,7 +241,7 @@ uint32_t SymbolVendor::ResolveSymbolCont
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ResolveSymbolContext(so_addr, resolve_scope, sc);
   }
   return 0;
@@ -254,7 +254,7 @@ uint32_t SymbolVendor::ResolveSymbolCont
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->ResolveSymbolContext(file_spec, line, check_inlines,
                                                  resolve_scope, sc_list);
   }
@@ -268,7 +268,7 @@ SymbolVendor::FindGlobalVariables(const
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->FindGlobalVariables(name, parent_decl_ctx,
                                                 max_matches, variables);
   }
@@ -281,7 +281,7 @@ size_t SymbolVendor::FindGlobalVariables
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->FindGlobalVariables(regex, max_matches, variables);
   }
   return 0;
@@ -295,7 +295,7 @@ size_t SymbolVendor::FindFunctions(const
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->FindFunctions(name, parent_decl_ctx, name_type_mask,
                                           include_inlines, append, sc_list);
   }
@@ -308,7 +308,7 @@ size_t SymbolVendor::FindFunctions(const
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->FindFunctions(regex, include_inlines, append,
                                           sc_list);
   }
@@ -323,7 +323,7 @@ size_t SymbolVendor::FindTypes(
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->FindTypes(name, parent_decl_ctx, append,
                                       max_matches, searched_symbol_files,
                                       types);
@@ -338,7 +338,7 @@ size_t SymbolVendor::FindTypes(const std
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->FindTypes(context, append, types);
   }
   if (!append)
@@ -351,7 +351,7 @@ size_t SymbolVendor::GetTypes(SymbolCont
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       return m_sym_file_ap->GetTypes(sc_scope, type_mask, type_list);
   }
   return 0;
@@ -364,7 +364,7 @@ SymbolVendor::FindNamespace(const ConstS
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
-    if (m_sym_file_ap.get())
+    if (m_sym_file_ap)
       namespace_decl_ctx = m_sym_file_ap->FindNamespace(name, parent_decl_ctx);
   }
   return namespace_decl_ctx;
@@ -380,7 +380,7 @@ void SymbolVendor::Dump(Stream *s) {
     s->Printf("%p: ", static_cast<void *>(this));
     s->Indent();
     s->PutCString("SymbolVendor");
-    if (m_sym_file_ap.get()) {
+    if (m_sym_file_ap) {
       *s << " " << m_sym_file_ap->GetPluginName();
       ObjectFile *objfile = m_sym_file_ap->GetObjectFile();
       if (objfile) {
@@ -402,7 +402,7 @@ void SymbolVendor::Dump(Stream *s) {
     cu_end = m_compile_units.end();
     for (cu_pos = m_compile_units.begin(); cu_pos != cu_end; ++cu_pos) {
       // We currently only dump the compile units that have been parsed
-      if (cu_pos->get())
+      if (*cu_pos)
         (*cu_pos)->Dump(s, show_context);
     }
 
@@ -431,7 +431,7 @@ CompUnitSP SymbolVendor::GetCompileUnitA
 }
 
 FileSpec SymbolVendor::GetMainFileSpec() const {
-  if (m_sym_file_ap.get()) {
+  if (m_sym_file_ap) {
     const ObjectFile *symfile_objfile = m_sym_file_ap->GetObjectFile();
     if (symfile_objfile)
       return symfile_objfile->GetFileSpec();
@@ -476,7 +476,7 @@ void SymbolVendor::SectionFileAddressesC
   ModuleSP module_sp(GetModule());
   if (module_sp) {
     ObjectFile *module_objfile = module_sp->GetObjectFile();
-    if (m_sym_file_ap.get()) {
+    if (m_sym_file_ap) {
       ObjectFile *symfile_objfile = m_sym_file_ap->GetObjectFile();
       if (symfile_objfile != module_objfile)
         symfile_objfile->SectionFileAddressesChanged();

Modified: lldb/trunk/source/Target/Language.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Language.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Target/Language.cpp (original)
+++ lldb/trunk/source/Target/Language.cpp Mon Feb 11 19:47:39 2019
@@ -390,7 +390,7 @@ bool Language::ImageListTypeScavenger::F
     images.FindTypes(nullptr, cs_key, false, UINT32_MAX, searched_sym_files,
                      matches);
     for (const auto &match : matches.Types()) {
-      if (match.get()) {
+      if (match) {
         CompilerType compiler_type(match->GetFullCompilerType());
         compiler_type = AdjustForInclusion(compiler_type);
         if (!compiler_type)

Modified: lldb/trunk/source/Target/SectionLoadHistory.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/SectionLoadHistory.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Target/SectionLoadHistory.cpp (original)
+++ lldb/trunk/source/Target/SectionLoadHistory.cpp Mon Feb 11 19:47:39 2019
@@ -80,7 +80,7 @@ SectionLoadHistory::GetSectionLoadListFo
       StopIDToSectionLoadList::reverse_iterator rpos =
           m_stop_id_to_section_load_list.rbegin();
       SectionLoadListSP section_load_list_sp(
-          new SectionLoadList(*rpos->second.get()));
+          new SectionLoadList(*rpos->second));
       m_stop_id_to_section_load_list[stop_id] = section_load_list_sp;
       return section_load_list_sp.get();
     }

Modified: lldb/trunk/source/Target/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Target.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Target/Target.cpp (original)
+++ lldb/trunk/source/Target/Target.cpp Mon Feb 11 19:47:39 2019
@@ -3150,7 +3150,7 @@ Target::StopHook::StopHook(const StopHoo
       m_commands(rhs.m_commands), m_specifier_sp(rhs.m_specifier_sp),
       m_thread_spec_ap(), m_active(rhs.m_active) {
   if (rhs.m_thread_spec_ap)
-    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap.get()));
+    m_thread_spec_ap.reset(new ThreadSpec(*rhs.m_thread_spec_ap));
 }
 
 Target::StopHook::~StopHook() = default;

Modified: lldb/trunk/source/Target/Thread.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Thread.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/source/Target/Thread.cpp (original)
+++ lldb/trunk/source/Target/Thread.cpp Mon Feb 11 19:47:39 2019
@@ -562,7 +562,7 @@ bool Thread::RestoreRegisterStateFromChe
         // Clear out all stack frames as our world just changed.
         ClearStackFrames();
         reg_ctx_sp->InvalidateIfNeeded(true);
-        if (m_unwinder_ap.get())
+        if (m_unwinder_ap)
           m_unwinder_ap->Clear();
         return ret;
       }

Modified: lldb/trunk/unittests/Editline/EditlineTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Editline/EditlineTest.cpp?rev=353795&r1=353794&r2=353795&view=diff
==============================================================================
--- lldb/trunk/unittests/Editline/EditlineTest.cpp (original)
+++ lldb/trunk/unittests/Editline/EditlineTest.cpp Mon Feb 11 19:47:39 2019
@@ -62,7 +62,7 @@ public:
 
   void CloseInput();
 
-  bool IsValid() const { return _editline_sp.get() != nullptr; }
+  bool IsValid() const { return _editline_sp != nullptr; }
 
   lldb_private::Editline &GetEditline() { return *_editline_sp; }
 




More information about the lldb-commits mailing list