[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

Eugene Zelenko via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 11 14:40:25 PST 2019


Eugene.Zelenko added inline comments.


================
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:10
 #include "ProcessMinidump.h"
+
 #include "ThreadMinidump.h"
----------------
Spurious separator.


================
Comment at: lldb/source/Plugins/Process/minidump/ThreadMinidump.cpp:10
 #include "ThreadMinidump.h"
+
 #include "ProcessMinidump.h"
----------------
Spurious separator.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:11
 
+#include <memory>
+
----------------
Wrong place.


================
Comment at: lldb/tools/debugserver/source/debugserver.cpp:14
 #include <getopt.h>
+#include <memory>
 #include <netdb.h>
----------------
Wrong place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57990/new/

https://reviews.llvm.org/D57990





More information about the lldb-commits mailing list