[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link	when it is not in 'compiler dir'
    Pavel Labath via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Mon Feb 11 05:42:55 PST 2019
    
    
  
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: lldb/lit/helper/build.py:296
+        if linker_path is None:
             raise ValueError('Could not find \'{}\''.format(linker_path))
         return linker_path
----------------
`linker_path` isn't going to be terribly useful here when it's none. Probably just replace it with `name`.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58001/new/
https://reviews.llvm.org/D58001
    
    
More information about the lldb-commits
mailing list