[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I agree with Eugene that the empty lines interfere with clang-format and that llvm does not use empty lines between system and own headers. However, our headers are already very inconsistent with that, so I don't think fixing that should be a part of this patch. It would be good if this patch did not make the problem worse though, which in some cases it does: e.g. in SBInstruction.cpp, `<memory>` is inserted into a middle of a `SB` include group together with an empty line,  which prevents clang-format from fixing this up.

Apart from that, this lgtm. Lldb does use weak_ptrs in a bunch of places, but I'm not terribly worried about the memory impact of this change.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57990/new/

https://reviews.llvm.org/D57990