[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 184825.
JDevlieghere marked 27 inline comments as done.
JDevlieghere added a comment.

Address Pavel's inline comments, modulo

- Fixing the ODR violation (should be easier to verify inline comments are addressed before moving the code).
- Fixing the endianness in the unit test  (I originally considered ifdef'ing this, but that combined with the float-encoding made me reconsider).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56322/new/

https://reviews.llvm.org/D56322

Files:
  include/lldb/API/SBReproducer.h
  source/API/CMakeLists.txt
  source/API/SBReproducer.cpp
  source/API/SBReproducerPrivate.h
  tools/driver/Driver.cpp
  unittests/API/CMakeLists.txt
  unittests/API/SBReproducerTest.cpp
  unittests/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56322.184825.patch
Type: text/x-patch
Size: 39001 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190201/7761af53/attachment-0001.bin>