[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

[Jim Ingham via Phabricator via lldb-commits]

jingham marked 5 inline comments as done.
jingham added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/source-map/TestTargetSourceMap.py:32-34
+        #bp = target.BreakpointCreateByLocation(src_path, 2)
+        #self.assertTrue(bp.GetNumLocations() == 1,
+        #                "make sure breakpoint was resolved with map")
----------------
labath wrote:
> Is this intentional?
No.  The test still passes with these uncommented!


================
Comment at: source/Target/PathMappingList.cpp:207
+    
+    if (orig_path.size() > 0) {
+      llvm::StringRef orig_ref(orig_path);
----------------
labath wrote:
> `!orig_path.empty()`?
Doh!


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57552/new/

https://reviews.llvm.org/D57552