[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 31 10:53:10 PST 2019

labath added a comment.

I was going to say that this has the potential of breaking libstdc++ formatters, but it looks like you found that out already. Since the libc++ inline namespace can really be anything, it makes sense to have the regex match that. Since libstdc++ (AFAIK) doesn't have that functionality, we can get away with it by moving it's formatters to the front. If we end up having two c++ standard libraries with configurable inline namespaces, we may have to do something smarter, like having a single regex, but then dispatching the implementation based on the presence of some member variable or something...



More information about the lldb-commits mailing list