[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

[Leonid Mashinskiy via Phabricator via lldb-commits]

leonid.mashinskiy added inline comments.


================
Comment at: source/Expression/DWARFExpression.cpp:3253
 
-  return false;
+  return true;
 }
----------------
zturner wrote:
> Why do we change the return value here?
This function had mixed return value semantics and I changed it to always returning true on success and false on failure.
Nobody checked return value before and I use it in unit tests.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55122/new/

https://reviews.llvm.org/D55122