[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 30 10:23:44 PST 2019

davide marked an inline comment as done.
davide added inline comments.

Comment at: lldb/source/Utility/Scalar.cpp:168
+      swapped_words[6] = apint_words[1];
+      swapped_words[7] = apint_words[0];
+      apint_words = swapped_words;
davide wrote:
> aprantl wrote:
> > std::reverse perhaps?
> We might want to change this everywhere.
I updated the comment but I can't really easily use `std::swap` or `std::reverse` because they operate on vectors and the unit of currency here is an array.
I thought about initializing a vector from the array we read and then call `std::reverse` (and then covert back to a pointer), but that didn't seem better than what we have now (or, at least, less ugly).



More information about the lldb-commits mailing list