[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux
Davide Italiano via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 29 14:45:30 PST 2019
davide added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792
+ assert(encodedBits.repr.unused == 0);
+ decodedBits.repr.sign = encodedBits.repr.sign;
+ decodedBits.repr.fraction = encodedBits.repr.fraction;
+ decodedBits.repr.exponent = decodeExponent(encodedBits.repr.exponent);
> davide wrote:
> > This bit is fine, and it's the only one I can comment on, because I wrote it.
> Your using the inactive member of union which is UB in C++.
That's clearly orthogonal to the change he made, which I suppose is a warning about unnamed unions.
CHANGES SINCE LAST ACTION
More information about the lldb-commits