[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792
+  assert(encodedBits.repr.unused == 0);
+  decodedBits.repr.sign = encodedBits.repr.sign;
+  decodedBits.repr.fraction = encodedBits.repr.fraction;
+  decodedBits.repr.exponent = decodeExponent(encodedBits.repr.exponent);
----------------
davide wrote:
> This bit is fine,  and it's the only one I can comment on, because I wrote it.
Your using the inactive member of union which is UB in C++.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57413/new/

https://reviews.llvm.org/D57413