[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 29 14:22:29 PST 2019


davide added a comment.

the changes that touch code I wrote lgtm.



================
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792
+  assert(encodedBits.repr.unused == 0);
+  decodedBits.repr.sign = encodedBits.repr.sign;
+  decodedBits.repr.fraction = encodedBits.repr.fraction;
+  decodedBits.repr.exponent = decodeExponent(encodedBits.repr.exponent);
----------------
This bit is fine,  and it's the only one I can comment on, because I wrote it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57413/new/

https://reviews.llvm.org/D57413





More information about the lldb-commits mailing list