[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 29 13:25:36 PST 2019


zturner created this revision.
zturner added reviewers: davide, JDevlieghere, jingham.

Most of these are surrounding the ObjectiveC formatters.  They use a lot of unions containing unnamed structs, which are not ISO C++ compliant and which gcc warns about.  There are several other minor warnings like unused variables, etc.

The ObjectiveC ones look NFC to me, because they basically just delete some structure / union members that are never read, but I'm throwing this up here for review anyway just to be on the safe side.


https://reviews.llvm.org/D57413

Files:
  lldb/source/Commands/CommandObjectReproducer.cpp
  lldb/source/Plugins/Language/ObjC/Cocoa.cpp
  lldb/source/Plugins/Language/ObjC/NSArray.cpp
  lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
  lldb/source/Plugins/Language/ObjC/NSSet.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57413.184163.patch
Type: text/x-patch
Size: 5901 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190129/7da8404c/attachment-0001.bin>


More information about the lldb-commits mailing list