[Lldb-commits] [PATCH] D57363: Fix handling of CreateTemplateParameterList when there is an empty pack

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added inline comments.


================
Comment at: packages/Python/lldbsuite/test/expression_command/radar_47565290/main.cpp:1
+template <typename N, typename P, class... O>
+class A {
----------------
Maybe I miss something, but this could be simpler I think? E.g. like this:
```
template <typename N, class... P>
struct A {
    int foo() { return 1;}
};

int main() {
  A<int> b;
  return b.foo(); // break here
}
```


================
Comment at: source/Symbol/ClangASTContext.cpp:1558
+
+    if (template_param_infos.packed_args->args.size()) {
+
----------------
I think `!template_param_infos.packed_args->args.empty()` is more LLVM-ish.


================
Comment at: source/Symbol/ClangASTContext.cpp:1562
+        template_param_decls.push_back(NonTypeTemplateParmDecl::Create(
+            *ast, decl_context, SourceLocation(), SourceLocation(), depth,
+            num_template_params, identifier_info,
----------------
aprantl wrote:
> does this get more or less readable if we replace `SourceLocation()` with `{}`?
We have `SourceLocation()` everywhere in clang, so it is at least more consistent this way IMHO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57363/new/

https://reviews.llvm.org/D57363