[Lldb-commits] [PATCH] D57273: Make Type::GetByteSize optional
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 28 13:48:20 PST 2019
aprantl added a comment.
Pavel, I may need you help. I reverted the commit because it broke three PDB-related tests (SymbolFilePDBTests, func-symbols, and typedefs) that need more than just lld in order to run. The fix is probably trivial. We only need to set a breakpoint in `Type.cpp:119` and every time a type with size 0 is passed in look at the frame we're coming from and make sure that that llvm::None is passed in instead of 0, similar to the changes in `DWARFASTParserClang.cpp`.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57273/new/
https://reviews.llvm.org/D57273
More information about the lldb-commits
mailing list