[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

[Davide Italiano via Phabricator via lldb-commits]

davide marked 2 inline comments as done.
davide added inline comments.


================
Comment at: lldb/source/Utility/RegisterValue.cpp:159
     case 32:
+    case 64:
       if (buffer.length % sizeof(uint64_t) == 0) {
----------------
aprantl wrote:
> I'm curious, everything else in this patch refers to 512, how does this fit in?
512 bits / 8 (bits per byte) = 64 bytes.
I can change the number to be in bits, if you want.


================
Comment at: lldb/source/Utility/Scalar.cpp:168
+      swapped_words[6] = apint_words[1];
+      swapped_words[7] = apint_words[0];
+      apint_words = swapped_words;
----------------
aprantl wrote:
> std::reverse perhaps?
We might want to change this everywhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57213/new/

https://reviews.llvm.org/D57213