[Lldb-commits] [lldb] r352158 - Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress

[Davide Italiano via lldb-commits]

Nice!

On Thu, Jan 24, 2019 at 7:01 PM Jason Molenda via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
>
> Author: jmolenda
> Date: Thu Jan 24 19:01:48 2019
> New Revision: 352158
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352158&view=rev
> Log:
> Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress
> when the binary loaded in memory has a section that we cannot find
> in the on-disk version.  I added this warning out of an overabundance
> of caution originally, but I've never seen an instance of it being
> hit in the past few years, and there are some changes for the shared
> cache on darwin systems where a segment is added when the shared
> cache is constructed so we're now hitting this warning.  I've decided
> to remove it altogether.
>
> <rdar://problem/46889346>
>
>
> Modified:
>     lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
>
> Modified: lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp?rev=352158&r1=352157&r2=352158&view=diff
> ==============================================================================
> --- lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp (original)
> +++ lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp Thu Jan 24 19:01:48 2019
> @@ -255,15 +255,7 @@ bool DynamicLoaderDarwin::UpdateImageLoa
>
>                changed = m_process->GetTarget().SetSectionLoadAddress(
>                    section_sp, new_section_load_addr, warn_multiple);
> -            } else {
> -              Host::SystemLog(
> -                  Host::eSystemLogWarning,
> -                  "warning: unable to find and load segment named '%s' at "
> -                  "0x%" PRIx64 " in '%s' in macosx dynamic loader plug-in.\n",
> -                  info.segments[i].name.AsCString("<invalid>"),
> -                  (uint64_t)new_section_load_addr,
> -                  image_object_file->GetFileSpec().GetPath().c_str());
> -            }
> +            }
>            }
>          }
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits