[Lldb-commits] [PATCH] D57037: BreakpadRecords: Address post-commit feedback

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 21 14:06:43 PST 2019


labath created this revision.
labath added a reviewer: lemo.

This addresses the issues raised in D56844 <https://reviews.llvm.org/D56844>. It removes the accessors from the
breakpad record structures by making the fields public. Also, I refactor the
UUID parsing code to remove hard-coded constants.


https://reviews.llvm.org/D57037

Files:
  source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp
  source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h
  source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp
  source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57037.182828.patch
Type: text/x-patch
Size: 8816 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190121/f6a80955/attachment.bin>


More information about the lldb-commits mailing list