[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin
Tatyana Krasnukha via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 21 12:02:06 PST 2019
tatyana-krasnukha added inline comments.
================
Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:29
+ PluginManager::RegisterPlugin(GetPluginNameStatic(),
+ "ARC-specific algorithms",
+ &ArchitectureArc::Create);
----------------
clayborg wrote:
> Not a great human readable architecture name here. All other plug-ins use the short architecture name ("arm", "mipc", "ppc64"). Best to just use "arc"?
You are writing about GetPluginNameStatic. The description string is same as for other plug-ins (just copy-pasted).
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55718/new/
https://reviews.llvm.org/D55718
More information about the lldb-commits
mailing list