[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 21 07:06:21 PST 2019


labath added inline comments.


================
Comment at: include/lldb/Host/Config.h.cmake:32-40
 #ifndef HAVE_LIBCOMPRESSION
 #cmakedefine HAVE_LIBCOMPRESSION
 #endif
 
+#ifndef HAVE_LIBCOMPRESSION
+#ifdef __APPLE__
+#define HAVE_LIBCOMPRESSION
----------------
teemperor wrote:
> labath wrote:
> > Why is this even necessary? If libcompression is always available on apple platforms, then the cmake check should always succeed, and there should be no need to fix it up. Maybe the check needs to be fixed/improved?
> I don't think I found a good answer for that in the git log. Maybe it's a workaround for the Xcode project?
That shouldn't be necessary. XCode has a special version of this file at `include/lldb/Host/Config.h`. However, it looks like this macro is not defined there. So maybe all that's needed is to hardcode `#define HAVE_LIBCOMPRESSION` there?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57011/new/

https://reviews.llvm.org/D57011





More information about the lldb-commits mailing list