[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.


================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1222-1223
+      
+      if (!arch_plugin->SetFeatures(reg_reader) && log)
+        log->PutCString("Failed to set architecture features");
+
----------------
clayborg wrote:
> All this work should be done in this function then use arch_plug->GetFlags().Set(mask);
Then I'll return to polluting this code with ARC-specific flags and registers.

I would avoid passing this monstrous `reg_reader` to the Architecture if I could pass RegisterContext there. However, RegisterContext doesn't exist yet at this step. And there is no entity that can read registers without a context.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55718/new/

https://reviews.llvm.org/D55718