[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

Thu Jan 17 10:42:16 PST 2019

clayborg added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707
   if (comm.GetQXferLibrariesSVR4ReadSupported()) {
     list.clear();

----------------
My two cents: I fully support a stub being able to provide the register info for DWARF, but it doesn't need to if there are well defined ABI plug-ins or architecture plug-ins that can assist. Why? It allows people to use a different lldb-server and test out new compiler changes without having to modify LLDB itself. There are kernel debugging tools that provide GDB server connections, and it is great to be able to let them iterate on their compilers and debugger connections without having to change LLDB. So yes, I am all for not requiring a stub to provide them as long as we can put the functionality in a good place.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55718/new/

https://reviews.llvm.org/D55718