[Lldb-commits] [PATCH] D56741: [CMake] Explicitly list User32 as dependency of lldb-mi

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

As far as I can tell, this dialog is only used when you build the lldb-mi with MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG, which you would only do if you wanted to debug lldb-mi.  The point is to stall the lldb-mi launch at an early point till you've gotten a debugger attached to it.  Then you can click the MessageBox OK to let lldb-mi proceed.  On all the other systems it does a while (var) sleep; type thing, so you attach and change the value of var with the expression parser and continue.

While the MessageBox implementation is cute, setting the var value should work just as well.  It certainly doesn't seem worth dragging UI into lldb-mi just for this purpose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56741/new/

https://reviews.llvm.org/D56741