[Lldb-commits] [PATCH] D56590: breakpad: Add FUNC records to the symtab

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:232
+  };
+  for (llvm::StringRef line: lines(*m_obj_file, Token::Func)) {
+    // Here we can get either FUNC records (starting with FUNC), or line records
----------------
Should the iterator for Token::Func just return "FUNC" objects only? Maybe we add a Token::Line to the Token enumeration and then add an optional second parameter to the iterator? So any code that would want a "FUNC" and its lines, would do:

```
for (llvm::StringRef line: lines(*m_obj_file, Token::Func, Token::Line)) {
}
```


================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:240
+
+    parse(line, true);
   }
----------------
If we modify the iterator this would become:
```
parse(lldb_private::breakpad::Line(line));
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56590/new/

https://reviews.llvm.org/D56590