[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

Tue Jan 15 07:12:06 PST 2019

clayborg added inline comments.

================
Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:858

+Status ProcessWindows::GetFileLoadAddress(const FileSpec &file, bool &is_loaded,
+                                          lldb::addr_t &load_addr) {
----------------
asmith wrote:
> clayborg wrote:
> > This entire function is doing the job of the dynamic loader and should be moved into the dynamic loader.
> when do you think the changes you mentioned for the loader and lldb-server.exe would be available for review? should we abandon this and wait for those?
I am saying the DynamicLoaderWindowsDYLD should be fixed, so that no matter how we connect to a windows process, we get correct DYLD functionality. The way this patch is currently coded, you require every process plug-in that connects to windows processes to have this work around. 

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56237/new/

https://reviews.llvm.org/D56237