[Lldb-commits] [lldb] r350950 - Fix build breaks after the ParseCompileUnit changes.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 11 10:35:58 PST 2019


Author: zturner
Date: Fri Jan 11 10:35:58 2019
New Revision: 350950

URL: http://llvm.org/viewvc/llvm-project?rev=350950&view=rev
Log:
Fix build breaks after the ParseCompileUnit changes.

The addition of SymbolFileBreakpad crossed paths with my change,
so this interface needs to be fixed up as well.

Modified:
    lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
    lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h

Modified: lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp?rev=350950&r1=350949&r2=350950&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp Fri Jan 11 10:35:58 2019
@@ -115,12 +115,12 @@ CompUnitSP SymbolFileBreakpad::ParseComp
   return nullptr;
 }
 
-size_t SymbolFileBreakpad::ParseCompileUnitFunctions(const SymbolContext &sc) {
+size_t SymbolFileBreakpad::ParseFunctions(CompileUnit &comp_unit) {
   // TODO
   return 0;
 }
 
-bool SymbolFileBreakpad::ParseCompileUnitLineTable(const SymbolContext &sc) {
+bool SymbolFileBreakpad::ParseLineTable(CompileUnit &comp_unit) {
   // TODO
   return 0;
 }

Modified: lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h?rev=350950&r1=350949&r2=350950&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h Fri Jan 11 10:35:58 2019
@@ -53,23 +53,21 @@ public:
 
   lldb::CompUnitSP ParseCompileUnitAtIndex(uint32_t index) override;
 
-  lldb::LanguageType
-  ParseCompileUnitLanguage(const SymbolContext &sc) override {
+  lldb::LanguageType ParseLanguage(CompileUnit &comp_unit) override {
     return lldb::eLanguageTypeUnknown;
   }
 
-  size_t ParseCompileUnitFunctions(const SymbolContext &sc) override;
+  size_t ParseFunctions(CompileUnit &comp_unit) override;
 
-  bool ParseCompileUnitLineTable(const SymbolContext &sc) override;
+  bool ParseLineTable(CompileUnit &comp_unit) override;
 
-  bool ParseCompileUnitDebugMacros(const SymbolContext &sc) override {
-    return false;
-  }
+  bool ParseDebugMacros(CompileUnit &comp_unit) override { return false; }
 
-  bool ParseCompileUnitSupportFiles(const SymbolContext &sc,
-                                    FileSpecList &support_files) override {
+  bool ParseSupportFiles(CompileUnit &comp_unit,
+                         FileSpecList &support_files) override {
     return false;
   }
+  size_t ParseTypes(CompileUnit &cu) override { return 0; }
 
   bool
   ParseImportedModules(const SymbolContext &sc,
@@ -86,7 +84,6 @@ public:
     return 0;
   }
 
-  size_t ParseTypesForCompileUnit(CompileUnit &cu) override { return 0; }
   size_t ParseVariablesForContext(const SymbolContext &sc) override {
     return 0;
   }




More information about the lldb-commits mailing list