[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

[Pavel Labath via Phabricator via lldb-commits]

labath updated this revision to Diff 181261.
labath added a comment.

- move the comp_dir resolution logic from SymbolFileDWARF to DWARFUnit
- this required the addition on an accessor to the "comp_dir_symlinks" setting, which is used in the full comp_dir resolution
- add FileSpec::MakeAbsolute() to simplify bits of code
- determine the path style from the DW_AT_name field if DW_AT_comp_dir is missing (I recall that it is possible to get a CU without a comp_dir in some circumstances, but I wasn't able to get my compiler to do that).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56543/new/

https://reviews.llvm.org/D56543

Files:
  include/lldb/Utility/FileSpec.h
  lit/SymbolFile/DWARF/Inputs/dir-separator-posix.lldbinit
  lit/SymbolFile/DWARF/Inputs/dir-separator-windows.lldbinit
  lit/SymbolFile/DWARF/dir-separator-no-comp-dir.s
  lit/SymbolFile/DWARF/dir-separator-posix.s
  lit/SymbolFile/DWARF/dir-separator-windows.s
  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h
  source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
  source/Plugins/SymbolFile/DWARF/DWARFUnit.h
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  source/Utility/FileSpec.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56543.181261.patch
Type: text/x-patch
Size: 21368 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190111/0f000fc0/attachment-0001.bin>