[Lldb-commits] [PATCH] D56564: [SymbolFile] Make ParseCompileUnitXXX accept a CompileUnit&.

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

looks good to me.



================
Comment at: lldb/include/lldb/Symbol/SymbolFile.h:135
+                                 FileSpecList &support_files) = 0;
+  virtual size_t ParseTypes(CompileUnit &comp_unit) = 0;
+  virtual bool ParseIsOptimized(lldb_private::CompileUnit &comp_unit) {
----------------
You're not consistent in the namespace qualification of CompileUnit. I'd suggest removing the namespace qualification, since you're already in that namespace anyway...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56564/new/

https://reviews.llvm.org/D56564