[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1289
+    if (type)
+      (void)type->GetFullCompilerType();
+  }
----------------
The body of this loop is a little odd because it's disposing of all the results and is just going through the motions to get side-effects to happen.  I realize the root problem is with the design of the API.  Perhaps a comment for the uninitiated might point future readers in the right direction.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56461/new/

https://reviews.llvm.org/D56461