[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 10 09:55:11 PST 2019


zturner added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:255
 
+  void ComputePathStyle();
+
----------------
aprantl wrote:
> I would probably call this DetectPathStyle() since it's more a heuristic?
Maybe even `Guess` since `Compute` implies absolute certainty.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56543/new/

https://reviews.llvm.org/D56543





More information about the lldb-commits mailing list