[Lldb-commits] [lldb] r350835 - [opaque pointer types] Remove some calls to generic Type subtype accessors.

James Y Knight via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 10 08:07:20 PST 2019

Author: jyknight
Date: Thu Jan 10 08:07:20 2019
New Revision: 350835

URL: http://llvm.org/viewvc/llvm-project?rev=350835&view=rev
[opaque pointer types] Remove some calls to generic Type subtype accessors.

That is, remove many of the calls to Type::getNumContainedTypes(),
Type::subtypes(), and Type::getContainedType(N).

I'm not intending to remove these accessors -- they are
useful/necessary in some cases. However, removing the pointee type
from pointers would potentially break some uses, and reducing the
number of calls makes it easier to audit.


Modified: lldb/trunk/source/Expression/IRInterpreter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRInterpreter.cpp?rev=350835&r1=350834&r2=350835&view=diff
--- lldb/trunk/source/Expression/IRInterpreter.cpp (original)
+++ lldb/trunk/source/Expression/IRInterpreter.cpp Thu Jan 10 08:07:20 2019
@@ -1592,9 +1592,6 @@ bool IRInterpreter::Interpret(llvm::Modu
         // Check if this is a string literal or constant string pointer
         if (arg_ty->isPointerTy()) {
-          // Pointer to just one type
-          assert(arg_ty->getNumContainedTypes() == 1);
           lldb::addr_t addr = tmp_op.ULongLong();
           size_t dataSize = 0;

More information about the lldb-commits mailing list