[Lldb-commits] [PATCH] D56517: [Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jan 9 17:01:47 PST 2019
zturner added a comment.
It's probably fine the way it is. The biggest advantage of using `universal_newlines=True` is that the result will always be a `string` in both Python 2 and Python 3. This makes it easier to reason about subsequent code , but if you're not doing much with the subsequent code, it doesn't matter. In Python 2, the return type is a `Unicode` object, which is different than a `string`. For this code it's fine, it's just something to keep in mind in future code.
(BTW, if for whatever reason in the future we decide that we require a minimum of Python 3.7, we can change this to `text=True` and then it will "just work"
CHANGES SINCE LAST ACTION
More information about the lldb-commits