[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 9 16:18:56 PST 2019

zturner marked 2 inline comments as done.
zturner added inline comments.

Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:626
+    // a series of namespaces.
+    // FIXME: do this.
+    CVSymbol global = m_index.ReadSymbolRecord(uid.asGlobalSym());
lemo wrote:
> leftover comment?
Yep, thanks.

Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.h:70-74
+    if (m_kind == Struct || m_kind == Union)
+      return cvclass.Name;
+    if (m_kind == Enum)
+      return cvenum.Name;
+    return cvunion.Name;
lemo wrote:
> this, in isolation at least, reads very strange : for m_kind==Union return cvclass.Name and for everything else return cvunion.Name ?
Oops, that's a bug.  It's supposed to say 

if (m_kind == Struct || m_kind == Class)
  return cvclass.Name;

I think the rest of the function makes sense after that.  Thanks for catching that.



More information about the lldb-commits mailing list